Re: [PATCH 3/5] libdwfl: add interface for attaching to/detaching from threads

2019-10-31 Thread Omar Sandoval
On Thu, Oct 31, 2019 at 05:21:17PM +0100, Mark Wielaard wrote: > On Wed, 2019-10-30 at 16:49 -0700, Omar Sandoval wrote: > > On Wed, Oct 30, 2019 at 01:47:52PM +0100, Mark Wielaard wrote: > > > Also, if we would adopt dwfl_attach_thread then I think it should take > > > a Dwfl_Thread object not a p

Re: [PATCH 3/5] libdwfl: add interface for attaching to/detaching from threads

2019-10-31 Thread Mark Wielaard
On Wed, 2019-10-30 at 16:49 -0700, Omar Sandoval wrote: > On Wed, Oct 30, 2019 at 01:47:52PM +0100, Mark Wielaard wrote: > > Also, if we would adopt dwfl_attach_thread then I think it should take > > a Dwfl_Thread object not a pid/tid as argument. > > In that case, we'd probably want to expose the

Re: [PATCH 3/5] libdwfl: add interface for attaching to/detaching from threads

2019-10-30 Thread Omar Sandoval
On Wed, Oct 30, 2019 at 01:47:52PM +0100, Mark Wielaard wrote: > Hi Omar, > > On Mon, 2019-10-07 at 02:05 -0700, Omar Sandoval wrote: > > libdwfl has implementations of attaching to/detaching from threads > > and > > unwinding stack traces. However, that functionality is only available > > through

Re: [PATCH 3/5] libdwfl: add interface for attaching to/detaching from threads

2019-10-30 Thread Mark Wielaard
Hi Omar, On Mon, 2019-10-07 at 02:05 -0700, Omar Sandoval wrote: > libdwfl has implementations of attaching to/detaching from threads > and > unwinding stack traces. However, that functionality is only available > through the dwfl_thread_getframes interface, which isn't very flexible. > This adds