Re: [PATCH 2/3] libdw: Rewrite the memory handler to be thread-safe.

2019-10-24 Thread Mark Wielaard
Hi, On Mon, 2019-10-21 at 20:00 +0200, Mark Wielaard wrote: > I think we cannot use the atomic_load () function, but have to use > atomic_load_explicit. So it would become: > > diff --git a/libdw/dwarf_end.c b/libdw/dwarf_end.c > index fc573cb3..a2e94436 100644 > --- a/libdw/dwarf_end.c > +++ b/l

Re: [PATCH 2/3] libdw: Rewrite the memory handler to be thread-safe.

2019-10-21 Thread Mark Wielaard
Hi, On Mon, 2019-10-21 at 11:28 -0500, Jonathon Anderson wrote: > On Mon, Oct 21, 2019 at 18:13, Mark Wielaard wrote: > > Does that look reasonable? > > It does, although I would prefer: > > diff --git a/libdw/dwarf_end.c b/libdw/dwarf_end.c > index 9ca17212..6da9e0cd 100644 > --- a/libdw/dwarf

Re: [PATCH 2/3] libdw: Rewrite the memory handler to be thread-safe.

2019-10-21 Thread Jonathon Anderson
On Mon, Oct 21, 2019 at 18:13, Mark Wielaard wrote: Hi, Finally back to this patch series. On Thu, 2019-08-29 at 15:16 +0200, Mark Wielaard wrote: diff --git a/libdw/dwarf_end.c b/libdw/dwarf_end.c index 29795c10..fc573cb3 100644 --- a/libdw/dwarf_end.c +++ b/libdw/dwarf_end.c @@ -94,

Re: [PATCH 2/3] libdw: Rewrite the memory handler to be thread-safe.

2019-10-21 Thread Mark Wielaard
Hi, Finally back to this patch series. On Thu, 2019-08-29 at 15:16 +0200, Mark Wielaard wrote: > diff --git a/libdw/dwarf_end.c b/libdw/dwarf_end.c > index 29795c10..fc573cb3 100644 > --- a/libdw/dwarf_end.c > +++ b/libdw/dwarf_end.c > @@ -94,14 +94,15 @@ dwarf_end (Dwarf *dwarf) >/* And