Hi,
On Mon, Mar 16, 2020 at 01:05:26PM +0100, Mark Wielaard wrote:
> Thanks for looking into this so closely. I think it is best to just do
> as the example code does. Always call inflateEnd (), ignoring the
> return code and not care whether (in an error case) it might be called
> twice. And to m
Hi Matthias,
On Mon, Mar 16, 2020 at 12:42:22AM +0100, Matthias Maennich wrote:
> > Just before this hunk we do:
> >
> > if (likely (zrc == Z_OK))
> >zrc = inflateEnd (&z);
> >
> > So, zrc can be !Z_OK because the earlier inflateEnd() failed, which
> > might cause it to call inflateEnd() tw
Hi Mark!
Thanks for the quick response!
On Mon, Mar 16, 2020 at 12:10:51AM +0100, Mark Wielaard wrote:
Hi Matthias,
On Sun, 2020-03-15 at 23:03 +0100, Matthias Maennich via Elfutils-devel wrote:
__libelf_decompress would only cleanup zlib resources via inflateEnd()
in case inflating was succe
Hi Matthias,
On Sun, 2020-03-15 at 23:03 +0100, Matthias Maennich via Elfutils-devel wrote:
> __libelf_decompress would only cleanup zlib resources via inflateEnd()
> in case inflating was successful, but would leak memory if not. Fix this
> by calling inflateEnd() in the error case as well.
>
>
