Re: [PATCH] libdw: dwarf_formsdata should return a signed value

2018-01-15 Thread Mark Wielaard
On Mon, Jan 15, 2018 at 12:34:27PM +0100, Petr Machata wrote: > 2018-01-15 9:23 GMT+01:00 Mark Wielaard : > > On Mon, 2018-01-15 at 00:06 +0100, Petr Machata wrote: > >> Ugh, sorry about that. It's been a while since I last posted, I > >> forgot the routine! > > > > No worries at all. This is all m

Re: [PATCH] libdw: dwarf_formsdata should return a signed value

2018-01-15 Thread Petr Machata
2018-01-15 9:23 GMT+01:00 Mark Wielaard : > On Mon, 2018-01-15 at 00:06 +0100, Petr Machata wrote: >> Ugh, sorry about that. It's been a while since I last posted, I >> forgot the routine! > > No worries at all. This is all mechanics/boilerplate. > We have a buildbot now, which would have caught th

Re: [PATCH] libdw: dwarf_formsdata should return a signed value

2018-01-15 Thread Mark Wielaard
On Mon, 2018-01-15 at 00:06 +0100, Petr Machata wrote: > Ugh, sorry about that. It's been a while since I last posted, I > forgot the routine! No worries at all. This is all mechanics/boilerplate. We have a buildbot now, which would have caught that: https://builder.wildebeest.org/buildbot/ It doe

Re: [PATCH] libdw: dwarf_formsdata should return a signed value

2018-01-14 Thread Mark Wielaard
Hi Petr, On Sun, Jan 14, 2018 at 03:22:05AM +0100, Petr Machata wrote: > The function dwarf_formsdata is used for decoding signed values, but > except for the variable-length DW_FORM_sdata, it uses unsigned > primitives to decode the value. This is not a problem for 64-bit values, > but the smalle