Re: [PATCH] debuginfod-client: default to XDG cache.

2020-02-28 Thread Mark Wielaard
Hi Aaron, On Thu, 2020-02-27 at 19:00 -0500, Aaron Merey wrote: > On Fri, Feb 21, 2020 at 3:09 PM Mark Wielaard wrote: > > But I think that means we should only create the cachedir (either > > $XDG_CACHE_HOME or $HOME/.cache). Which is what we are doing here. But > > I don't think we are expected

Re: [PATCH] debuginfod-client: default to XDG cache.

2020-02-27 Thread Aaron Merey
On Fri, Feb 21, 2020 at 3:09 PM Mark Wielaard wrote: > I think the spec is slightly ambiguous whether or not you need to > create all parents. > https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html > >If, when attempting to write a file, the destination directory is >

Re: [PATCH] debuginfod-client: default to XDG cache.

2020-02-21 Thread Mark Wielaard
Hi Aaron, On Fri, 2020-02-21 at 12:21 -0500, Aaron Merey wrote: > On Fri, Feb 21, 2020 at 11:13 AM Mark Wielaard wrote: > > On Wed, 2020-02-19 at 16:04 -0500, Aaron Merey wrote: > > > + /* Create XDG cache directory if it doesn't exist. */ > > > + if (stat (cachedir, &st) == 0)

Re: [PATCH] debuginfod-client: default to XDG cache.

2020-02-21 Thread Aaron Merey
On Fri, Feb 21, 2020 at 11:13 AM Mark Wielaard wrote: > On Wed, 2020-02-19 at 16:04 -0500, Aaron Merey wrote: > > Location of client cache now defaults to $XDG_CACHE_HOME/debuginfod_client. > > If XDG_CACHE_HOME is not set then fallback to > > $HOME/.cache/debuginfod_client. > > Also maintain bac

Re: [PATCH] debuginfod-client: default to XDG cache.

2020-02-21 Thread Mark Wielaard
Hi Aaron, On Wed, 2020-02-19 at 16:04 -0500, Aaron Merey wrote: > From 8eb82eb58747078a3e914576a7c6ff3f7b2c7cb4 Mon Sep 17 00:00:00 2001 > From: Aaron Merey > Date: Wed, 19 Feb 2020 12:30:14 -0500 > Subject: [PATCH] PR25502: debuginfod-client default to XDG cache. > > Location of client cache no

Re: [PATCH] debuginfod-client: default to XDG cache.

2020-02-19 Thread Aaron Merey
Reposting the patch since the original contained a silly memory leak. From 8eb82eb58747078a3e914576a7c6ff3f7b2c7cb4 Mon Sep 17 00:00:00 2001 From: Aaron Merey Date: Wed, 19 Feb 2020 12:30:14 -0500 Subject: [PATCH] PR25502: debuginfod-client default to XDG cache. Location of client cache now defau