Re: [PATCH] configure: Add new --enable-install-elfh option.

2019-01-31 Thread Mark Wielaard
On Wed, Jan 30, 2019 at 09:54:53AM +, Ulf Hermann wrote: > > Yes, it should indeed. > > I used a slightly different solution though. > > It relies on the default include flags already including the srcdirs. > > Does that work for your use case too? (See revised patch attached.) > > I'm not an

Re: [PATCH] configure: Add new --enable-install-elfh option.

2019-01-30 Thread Ulf Hermann
> Yes, it should indeed. > I used a slightly different solution though. > It relies on the default include flags already including the srcdirs. > Does that work for your use case too? (See revised patch attached.) I'm not an expert in autotools. The reason I also have "else" case in my code is th

Re: [PATCH] configure: Add new --enable-install-elfh option.

2019-01-29 Thread Mark Wielaard
Hi Ulf, On Thu, Jan 24, 2019 at 06:53:15PM +0100, Mark Wielaard wrote: > On Fri, 2019-01-18 at 14:03 +, Ulf Hermann wrote: > > I think you should also adapt tests/Makefile.am to use our own elf.h > > in > > this case. See https://codereview.qt-project.org/#/c/187812/25 for > > my > > solutio

Re: [PATCH] configure: Add new --enable-install-elfh option.

2019-01-24 Thread Mark Wielaard
On Fri, 2019-01-18 at 14:03 +, Ulf Hermann wrote: > I think you should also adapt tests/Makefile.am to use our own elf.h > in > this case. See https://codereview.qt-project.org/#/c/187812/25 for > my > solution to this. Yes, it should indeed. I used a slightly different solution though. It r

Re: [PATCH] configure: Add new --enable-install-elfh option.

2019-01-18 Thread Ulf Hermann
I think you should also adapt tests/Makefile.am to use our own elf.h in this case. See https://codereview.qt-project.org/#/c/187812/25 for my solution to this.