Re: [PATCH] Link against standalone error library if available

2025-01-29 Thread parona
Hi, On Wednesday, January 29th, 2025 at 2:40 PM, Mark Wielaard wrote: > I definitely like this patch. But when doing an autoreconf -f -v -i > (autoconf 2.27) I get: > > autoheader: warning: missing template: HAVE_ERROR_H > autoheader: warning: Use AC_DEFINE([HAVE_ERROR_H], [], [Description]) >

Re: [PATCH] Link against standalone error library if available

2025-01-29 Thread Mark Wielaard
Hi, On Wed, Jan 29, 2025 at 07:57:37AM +, parona wrote: > On Monday, January 27th, 2025 at 10:40 PM, Mark Wielaard > wrote: > > So maybe our configure check is wrong and it should just test whether > > there is an error.h but also if you can link the result? > > Included patch that checks i

Re: [PATCH] Link against standalone error library if available

2025-01-28 Thread parona
Hi, On Monday, January 27th, 2025 at 10:40 PM, Mark Wielaard wrote: > My main question/confusion is where the error.h include comes from. > elfutils does support libcs like musl who don't provide error.h but do > provide err.h. Then the build should provide its own error function > through lib/sy

Re: [PATCH] Link against standalone error library if available

2025-01-27 Thread Mark Wielaard
Hi, On Mon, Jan 27, 2025 at 05:23:15AM +, parona wrote: > Background for this patch is https://bugs.gentoo.org/948878 where > are user had installed a standalone error implementation for a > different package leading to a build failure. There is also some discussion in this elfutils bug: http