Re: [PATCH] Don't look for kernel version if not running on linux

2017-05-02 Thread Mark Wielaard
On Tue, May 02, 2017 at 12:17:24PM +0200, Ulf Hermann wrote: > > You can get uname() on Windows through gnulib, but at the cost at > > linking to additional windows DLLs. It calls gethostname and for that > > we need to link against ws2_32.dll. That's an unreasonable dependency > > for getting some

Re: [PATCH] Don't look for kernel version if not running on linux

2017-05-02 Thread Ulf Hermann
You can get uname() on Windows through gnulib, but at the cost at linking to additional windows DLLs. It calls gethostname and for that we need to link against ws2_32.dll. That's an unreasonable dependency for getting something we cannot use anyway. I suggest we just set errno to ENOTSUP then. I

Re: [PATCH] Don't look for kernel version if not running on linux

2017-04-28 Thread Ulf Hermann
On 04/27/2017 08:02 PM, Mark Wielaard wrote: > On Thu, Apr 20, 2017 at 04:08:48PM +0200, Ulf Hermann wrote: >> We don't want to use it, even if it exists. > > I am not sure this is really the right place to patch. > The value is retrieved through uname () which is POSIX and so should > be availabl

Re: [PATCH] Don't look for kernel version if not running on linux

2017-04-27 Thread Mark Wielaard
On Thu, Apr 20, 2017 at 04:08:48PM +0200, Ulf Hermann wrote: > We don't want to use it, even if it exists. I am not sure this is really the right place to patch. The value is retrieved through uname () which is POSIX and so should be available even on non-GNU/Linux systems. When kernel_release ()