On 11/28/22 23:29, Mark Wielaard wrote:
Hi Martin,
On Mon, Nov 28, 2022 at 02:16:35PM +0100, Martin Liška wrote:
On 10/29/22 00:21, Mark Wielaard wrote:
Although I like to also have compression working. Then we can also
add support to src/elfcompress, which makes for a good testcase. See
test
Hi Martin,
On Mon, Nov 28, 2022 at 02:16:35PM +0100, Martin Liška wrote:
> On 10/29/22 00:21, Mark Wielaard wrote:
> > Although I like to also have compression working. Then we can also
> > add support to src/elfcompress, which makes for a good testcase. See
> > tests/run-compress.sh (which has f
On 10/29/22 00:21, Mark Wielaard wrote:
Although I like to also have compression working. Then we can also
add support to src/elfcompress, which makes for a good testcase. See
tests/run-compress.sh (which has found some subtle memory issues when
run under valgrind).
Hi.
All right, so I'm prep
Hi Martin,
On Mon, Oct 24, 2022 at 08:16:09PM +0200, Martin Liška wrote:
> Anyway, I'm sending V2 that works fine --with-zstd and --without-zstd as
> expected.
>
> Ready for master?
The decompression part looks good. Few small nitpicks below.
Although I like to also have compression working.
On 10/24/22 18:48, Dmitry V. Levin wrote:
> On Mon, Oct 24, 2022 at 02:17:17PM +0200, Martin Liška wrote:
>> On 10/24/22 13:41, Dmitry V. Levin wrote:
>>> On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote:
>>> [...]
One TODO I see is that:
+libelf_so_LDLIBS = $(libelf_so_DEPS)
On Mon, Oct 24, 2022 at 02:17:17PM +0200, Martin Liška wrote:
> On 10/24/22 13:41, Dmitry V. Levin wrote:
> > On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote:
> > [...]
> >> One TODO I see is that:
> >> +libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzstd
> >>
> >> should be conditional ba
On 10/24/22 13:41, Dmitry V. Levin wrote:
> On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote:
> [...]
>> One TODO I see is that:
>> +libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzstd
>>
>> should be conditional based on HAVE_ZSTD. But I don't know how to do that?
>
> I suppose you're tal
On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote:
[...]
> One TODO I see is that:
> +libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzstd
>
> should be conditional based on HAVE_ZSTD. But I don't know how to do that?
I suppose you're talking about libzstd_LIBS.
[...]
> diff --git a/m4/zst
