On 12/22/22 19:36, Mark Wielaard wrote:
> |See also my other email. I think that addresses everything. Just merge those
> and push please.|
Hi.
Thank you Mark for help! I've just finished the patch and pushed that to master.
Cheers,
Martin
Hi Martin,
On Thu, 2022-12-22 at 10:17 +0100, Martin Liška wrote:
> Is the abort () at the second call site because that cannot happen?
> > Or should that also goto cleanup?
>
> Yes, it can't happen.
Aha, because it should already have seen that section before, in which
case it would have errore
Hi.
> Is the abort () at the second call site because that cannot happen? Or
> should that also goto cleanup?
Yes, it can't happen.
There's V2 (including ChangeLog) where all issues apart from the libzstd
configure.ac detection
should be addressed.
Cheers,
Martin
config/ChangeLog:
*
Hi Martin,
On Wed, Dec 21, 2022 at 12:09:21PM +0100, Martin Liška wrote:
> > Or you return a special value from the function (assuming all callers
> > check for an error here). And/Or if the program needs a cleanup you'll
> > goto cleanup (as is done in process_file).
>
> I think it's fine as we
On 12/19/22 16:09, Mark Wielaard wrote:
> Hi Martin,
>
> On Mon, 2022-12-19 at 15:19 +0100, Martin Liška wrote:
>> On 12/15/22 14:17, Mark Wielaard wrote:
>>> Is there a particular way you are running eu-readelf? Is it with
>>> generic -w or -a, or decoding a specific section type?
>>
>> Hello.
>>
On 12/19/22 16:16, Mark Wielaard wrote:
> Hi Martin,
>
> On Mon, 2022-12-19 at 15:21 +0100, Martin Liška wrote:
+ else
+error (0, 0, "Couldn't get chdr for section %zd", ndx);
>>>
>>> Shouldn't this error be fatal?
>>
>> What do you use for fatal errors?
>
> Depends a bit on co
Hi Martin,
On Mon, 2022-12-19 at 15:21 +0100, Martin Liška wrote:
> > > + else
> > > +error (0, 0, "Couldn't get chdr for section %zd", ndx);
> >
> > Shouldn't this error be fatal?
>
> What do you use for fatal errors?
Depends a bit on context. It might be that this error isn't fatal,
Hi Martin,
On Mon, 2022-12-19 at 15:19 +0100, Martin Liška wrote:
> On 12/15/22 14:17, Mark Wielaard wrote:
> > Is there a particular way you are running eu-readelf? Is it with
> > generic -w or -a, or decoding a specific section type?
>
> Hello.
>
> $ LD_LIBRARY_PATH=./libelf ./src/readelf -w
>
Hi.
+ if (use_zstd)
+#ifdef USE_ZSTD
+return __libelf_compress_zstd (scn, hsize, ei_data, orig_size,
+ orig_addralign, new_size, force,
+ data, next_data, out_buf, out_size,
+ block);
+#else
+
On 12/15/22 14:17, Mark Wielaard wrote:
Hi Martin,
On Tue, 2022-11-29 at 13:05 +0100, Martin Liška wrote:
There's second version of the patch that fully support both
compression and decompression.
Changes from the v1:
- compression support added
- zstd detection is fixed
- new tests are added
Hi Martin,
On Tue, Nov 29, 2022 at 01:05:45PM +0100, Martin Liška wrote:
> diff --git a/libelf/elf_compress.c b/libelf/elf_compress.c
> index d7f53af2..7a6e37a4 100644
> --- a/libelf/elf_compress.c
> +++ b/libelf/elf_compress.c
> @@ -39,6 +39,10 @@
> #include
> #include
> +#ifdef USE_ZSTD
> +#
Hi Martin,
On Tue, 2022-11-29 at 13:05 +0100, Martin Liška wrote:
> There's second version of the patch that fully support both
> compression and decompression.
>
> Changes from the v1:
> - compression support added
> - zstd detection is fixed
> - new tests are added
> - builds fine w/ and w/o th
PING^1
On 11/29/22 13:05, Martin Liška wrote:
> Hi.
>
> There's second version of the patch that fully support both compression and
> decompression.
>
> Changes from the v1:
> - compression support added
> - zstd detection is fixed
> - new tests are added
> - builds fine w/ and w/o the ZSTD lib
Hi.
There's second version of the patch that fully support both compression and
decompression.
Changes from the v1:
- compression support added
- zstd detection is fixed
- new tests are added
- builds fine w/ and w/o the ZSTD library
What's currently missing and where I need a help:
1) When I
14 matches
Mail list logo
