Re: [PATCHv2] debuginfod: Check result of calling MHD_add_response_header.

2021-12-08 Thread Mark Wielaard
Hi Frank, On Wed, 2021-12-01 at 10:23 -0500, Frank Ch. Eigler wrote: > > Although unlikely the MHD_add_response_header can fail for > > various reasons. If it fails something odd is going on. > > So check we can actually add a response header and log an > > error if we cannot. > > TBH I wouldn't

Re: [PATCHv2] debuginfod: Check result of calling MHD_add_response_header.

2021-12-01 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > Although unlikely the MHD_add_response_header can fail for > various reasons. If it fails something odd is going on. > So check we can actually add a response header and log an > error if we cannot. TBH I wouldn't bother even this much checking. It just uglifies the code. If it would ma

[PATCHv2] debuginfod: Check result of calling MHD_add_response_header.

2021-12-01 Thread Mark Wielaard
Although unlikely the MHD_add_response_header can fail for various reasons. If it fails something odd is going on. So check we can actually add a response header and log an error if we cannot. Signed-off-by: Mark Wielaard --- This version only check and logs the error, but still uses the resp