Re: [PATCH v3] build: allow turning off --no-undefined and -z,defs

2021-12-08 Thread Evgeny Vereshchagin
Hi Mark, > But that doesn't really work if you use clang. It kind of does because almost everybody who builds their projects with clang sanitizers turns off `z,defs` and `--no-undefined`. I agree it looks weird (and it's probably weird) but it's just how it has been done for I don't know how ma

Re: [PATCH v3] build: allow turning off --no-undefined and -z,defs

2021-12-08 Thread Mark Wielaard
Hi Evgeny, On Sun, 2021-12-05 at 19:52 +0300, Evgeny Vereshchagin wrote: > > See how I used it to workaround isssues with the > > gcc address sanitizer. You can use it likewise to work around > > issues > > with clang. e.g. the configure check should detect the issue with > > --no-undefined and co

Re: [PATCH v3] build: allow turning off --no-undefined and -z,defs

2021-12-05 Thread Evgeny Vereshchagin
Hi Mark, > But it would help if you replied to the original > reviews and/or mentioned how the different versions of your patch have > changed since the last time. I did but it looks like those emails didn't pass the spam filter. I'll try to figure out what happened there. Sorry about that! >

Re: [PATCH v3] build: allow turning off --no-undefined and -z,defs

2021-12-05 Thread Mark Wielaard
Hi Evgeny, I really appreciate you helping us using more analyzers and fuzzers to improve the code base. I think the address sanitizer already helped improve the code. But it would help if you replied to the original reviews and/or mentioned how the different versions of your patch have changed si

[PATCH v3] build: allow turning off --no-undefined and -z,defs

2021-12-04 Thread Evgeny Vereshchagin
ASan, UBSan and MSan provided by clang aren't compatible with --no-undefined and -z,defs: https://clang.llvm.org/docs/AddressSanitizer.html#usage https://github.com/google/sanitizers/issues/380 so to build elfutils with clang with the sanitizers it should be possible to turn them off. It's implem