Re: ChangeLog entries (Was: [PATCH v3] Use fallthrough attribute)

2018-02-12 Thread Ulf Hermann
> For people that don't like them, what exactly is it about them that you > don't like? And what would you suggest as replacement? I don't like them because they constantly give me problems when merging and for me at least they only repeat, in a less convenient form, what the commit message alre

ChangeLog entries (Was: [PATCH v3] Use fallthrough attribute)

2018-02-10 Thread Mark Wielaard
On Fri, 2018-02-09 at 22:36 -0500, Frank Ch. Eigler wrote: > On Sat, Feb 10, 2018 at 03:26:43AM +0100, Mark Wielaard wrote: > > > I added ChangeLog entries and pushed it to master. > > What's a ChangeLog entry?  :-) Yeah, yeah, I know. I am the last one to care. Really, it helps me review code (

Re: [PATCH v3] Use fallthrough attribute

2018-02-09 Thread Frank Ch. Eigler
Hi - On Sat, Feb 10, 2018 at 03:26:43AM +0100, Mark Wielaard wrote: > I added ChangeLog entries and pushed it to master. What's a ChangeLog entry? :-) - FChE

Re: [PATCH v3] Use fallthrough attribute

2018-02-09 Thread Mark Wielaard
Hi Joshua, On Fri, Feb 09, 2018 at 10:27:18AM -0600, Joshua Watt wrote: > Use __attribute__ ((fallthrough)) to indicate switch case fall through > instead of a comment. This ensure that the fallthrough warning is not > triggered even if the file is pre-processed (hence stripping the > comments) be

[PATCH v3] Use fallthrough attribute

2018-02-09 Thread Joshua Watt
Use __attribute__ ((fallthrough)) to indicate switch case fall through instead of a comment. This ensure that the fallthrough warning is not triggered even if the file is pre-processed (hence stripping the comments) before it is compiled. The actual fallback implementation is hidden behind a FALLB