Re: [PATCH v2] debuginfod.cxx: include libintl.h.

2020-11-04 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > > YES PLEASE! :-) > > > > As a transition, how about ChangeLog format content in the git commit > > messages? > > You mean as done by GCC? Not have actual ChangeLog files, but add the > ChangeLog entries themselves in the commit message? > https://gcc.gnu.org/codingconventions.html#Change

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

2020-11-03 Thread Mark Wielaard
On Tue, 2020-11-03 at 12:16 -0500, Frank Ch. Eigler wrote: > Hi - > > > But don't take it too seriously. I seem to be the only person left > > in > > the project that loves ChangeLog entries. They really help me > > review > > what was changed. If too many contributors complain we can look at > >

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

2020-11-03 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > But don't take it too seriously. I seem to be the only person left in > the project that loves ChangeLog entries. They really help me review > what was changed. If too many contributors complain we can look at > alternatives. YES PLEASE! :-) As a transition, how about ChangeLog format con

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

2020-11-03 Thread Mark Wielaard
On Mon, 2020-11-02 at 23:44 -0300, Érico Nogueira via Elfutils-devel wrote: > On Mon Nov 2, 2020 at 10:17 PM -03, Mark Wielaard wrote: > > Thanks, added a ChangeLog entry and pushed. > > Sorry for missing these, and thank you for adding them. So, from what I > understand now, the policy is to add

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

2020-11-02 Thread Érico Nogueira via Elfutils-devel
On Mon Nov 2, 2020 at 10:17 PM -03, Mark Wielaard wrote: > On Sun, Nov 01, 2020 at 09:58:04PM -0300, Érico Nogueira via > Elfutils-devel wrote: > > From: Érico Rolim > > > > Uncomment the include, since textdomain() and > > bindtextdomain() functions provided by it are being used. > > > > Signe

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

2020-11-02 Thread Mark Wielaard
On Sun, Nov 01, 2020 at 09:58:04PM -0300, Érico Nogueira via Elfutils-devel wrote: > From: Érico Rolim > > Uncomment the include, since textdomain() and > bindtextdomain() functions provided by it are being used. > > Signed-off-by: Érico Rolim > --- > > This is a follow up to the patch that

[PATCH v2] debuginfod.cxx: include libintl.h.

2020-11-01 Thread Érico Nogueira via Elfutils-devel
From: Érico Rolim Uncomment the include, since textdomain() and bindtextdomain() functions provided by it are being used. Signed-off-by: Érico Rolim --- This is a follow up to the patch that went the opposite way and removed the calls to bindtextdomain() and textdomain(); it was decided that