Re: [PATCH v2] Stop depending on strndupa.

2020-10-27 Thread Érico Nogueira via Elfutils-devel
On Tue Oct 27, 2020 at 1:01 PM -03, Mark Wielaard wrote: > Hi Érico, > > On Mon, 2020-10-26 at 15:33 -0300, Érico Nogueira via Elfutils-devel > wrote: > > From: Érico Rolim > > > > This functon has inherent safety issues, since a long enough path can > > lead to memory clobbering. Instead, limit

Re: [PATCH v2] Stop depending on strndupa.

2020-10-27 Thread Mark Wielaard
Hi Érico, On Mon, 2020-10-26 at 15:33 -0300, Érico Nogueira via Elfutils-devel wrote: > From: Érico Rolim > > This functon has inherent safety issues, since a long enough path can > lead to memory clobbering. Instead, limit the path length to > PATH_MAX. I like getting rid of strndupa, because

[PATCH v2] Stop depending on strndupa.

2020-10-26 Thread Érico Nogueira via Elfutils-devel
From: Érico Rolim This functon has inherent safety issues, since a long enough path can lead to memory clobbering. Instead, limit the path length to PATH_MAX. As a bonus, this improves musl compatibility, since musl doesn't include the strndupa macro for now. Also add braces around while loop.