> "Mark" == Mark Wielaard writes:
Mark> Looks good. While reviewing I did try out some extra corner cases that
Mark> I added (see attached). It also shows that some values can have
Mark> multiple representations. I added them to your commit before I pushed
Mark> it. Hope you don't mind.
Seem
Hi Tom,
On Wed, 2020-10-28 at 17:26 -0600, Tom Tromey wrote:
> PR 26773 points out that some sleb128 values are decoded incorrectly.
>
> This version of the fix only examines the sleb128 conversion.
> Overlong encodings are not handled, and the uleb128 decoders are not
> touched. The approach ta
PR 26773 points out that some sleb128 values are decoded incorrectly.
This version of the fix only examines the sleb128 conversion.
Overlong encodings are not handled, and the uleb128 decoders are not
touched. The approach taken here is to do the work in an unsigned
type, and then rely on an impl
