Re: [PATCH V4 0/1] Add C-SKY support

2019-07-17 Thread Mark Wielaard
Hi Mao Han, On Wed, 2019-07-17 at 09:19 +0800, Mao Han wrote: > > The new patch looks really good. Thanks. The addition of the testcases > > really helps showing things look good. I can make that one small fix > > s/gnu/csky/ in csky_attrs.c if you agree that is what was intended. > > Then I'll pu

Re: [PATCH V4 0/1] Add C-SKY support

2019-07-16 Thread Mao Han
On Tue, Jul 16, 2019 at 03:48:22PM +0200, Mark Wielaard wrote: > > > > These attributes including cpu name and some other ISA related > > > > descriptions. > > > > Some thing like: > > > > CSKY_ARCH_NAME: "ck810" > > > > CSKY_CPU_NAME: "ck810f" > > > > CSKY_ISA_FLAG: 0x12345678 > > > > CSKY_ISA_E

Re: [PATCH V4 0/1] Add C-SKY support

2019-07-16 Thread Mark Wielaard
On Tue, 2019-07-16 at 19:14 +0800, Mao Han wrote: > > > The ELF_ARCH was defined as 39 inside linux kernel(before 4.20), > > > so > > > the the core file generated was EM_RCE. > > > I'v regenerated the core file with ELF_ARCH defined as 252: > > > https://github.com/c-sky/test-result/blob/master/el

[PATCH V4 0/1] Add C-SKY support

2019-07-16 Thread Mao Han
> > The ELF_ARCH was defined as 39 inside linux kernel(before 4.20), so > > the the core file generated was EM_RCE. > > I'v regenerated the core file with ELF_ARCH defined as 252: > > https://github.com/c-sky/test-result/blob/master/elfutils/zeroptr > > https://github.com/c-sky/test-result/raw/mast