Re: [PATCH 3/4] ar: Pull should_truncate_fname() into file scope

2021-02-02 Thread Timm Bäder via Elfutils-devel
On 29/01/2021 21:48, Mark Wielaard wrote: Hi Timm, On Fri, 2021-01-08 at 09:13 +0100, Timm Bäder via Elfutils-devel wrote: Get rid of a nested function this way. Skipping this one for now since I don't believe I understand this code. Could you explain what the code does what it does and why i

Re: [PATCH 3/4] ar: Pull should_truncate_fname() into file scope

2021-01-29 Thread Mark Wielaard
Hi Timm, On Fri, 2021-01-08 at 09:13 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. Skipping this one for now since I don't believe I understand this code. Could you explain what the code does what it does and why it works fine when moved this way? Thanks,

[PATCH 3/4] ar: Pull should_truncate_fname() into file scope

2021-01-08 Thread Timm Bäder via Elfutils-devel
From: Timm Bäder Get rid of a nested function this way. Signed-off-by: Timm Bäder --- src/ar.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/src/ar.c b/src/ar.c index 2a17d0d3..7d0298dd 100644 --- a/src/ar.c +++ b/src/ar.c @@ -436,6 +4