Re: [PATCH 2/5] backends: Add set_initial_registers_tid callback for LoongArch

2023-05-09 Thread Mark Wielaard
Hi Youling, On Tue, 2023-05-09 at 09:32 +0800, Youling Tang wrote: > Thanks for pointing out that there is no need to mask the lower 32 bits > here. > > It can be modified as follows, > --- a/backends/loongarch_initreg.c > +++ b/backends/loongarch_initreg.c > @@ -79,11 +79,8 @@ loongarch_set_init

Re: [PATCH 2/5] backends: Add set_initial_registers_tid callback for LoongArch

2023-05-08 Thread Youling Tang
On 05/09/2023 09:32 AM, Youling Tang wrote: Hi, Mark On 05/09/2023 03:57 AM, Mark Wielaard wrote: Him On Fri, Apr 07, 2023 at 10:59:25AM +0800, Youling Tang wrote: This patch implements the set_initial_registers_tid hook for LoongArch. Looks good, but one question: + /* Floating-point

Re: [PATCH 2/5] backends: Add set_initial_registers_tid callback for LoongArch

2023-05-08 Thread Youling Tang
Hi, Mark On 05/09/2023 03:57 AM, Mark Wielaard wrote: Him On Fri, Apr 07, 2023 at 10:59:25AM +0800, Youling Tang wrote: This patch implements the set_initial_registers_tid hook for LoongArch. Looks good, but one question: + /* Floating-point registers (only 64bits are used). */ + struct

Re: [PATCH 2/5] backends: Add set_initial_registers_tid callback for LoongArch

2023-05-08 Thread Mark Wielaard
Him On Fri, Apr 07, 2023 at 10:59:25AM +0800, Youling Tang wrote: > This patch implements the set_initial_registers_tid hook for LoongArch. Looks good, but one question: > + /* Floating-point registers (only 64bits are used). */ > + struct user_fp_struct fregs; > + iovec.iov_base = &fregs; >

[PATCH 2/5] backends: Add set_initial_registers_tid callback for LoongArch

2023-04-06 Thread Youling Tang
This patch implements the set_initial_registers_tid hook for LoongArch. Signed-off-by: Liwei Ge Signed-off-by: Youling Tang --- backends/ChangeLog | 6 +++ backends/Makefile.am | 2 +- backends/loongarch_init.c| 1 + backends/loongarch_initreg.c | 91 +++