Re: [PATCH 2/2] libdw: Rewrite the memory handler to be more robust.

2019-11-08 Thread Jonathon Anderson
On Fri, Nov 8, 2019 at 17:22, Mark Wielaard wrote: On Thu, 2019-11-07 at 12:40 -0600, Jonathon Anderson wrote: I haven't benchmarked this version, but I did benchmark the equivalent earlier version (this version is almost quite literally a rebase of the other). I don't have the exact res

Re: [PATCH 2/2] libdw: Rewrite the memory handler to be more robust.

2019-11-08 Thread Mark Wielaard
Hi, On Thu, 2019-11-07 at 12:13 -0600, Jonathon Anderson wrote: > On Thu, Nov 7, 2019 at 18:20, Mark Wielaard wrote: > > Do we really need this? > > We already use __thread unconditionally in the rest of the code. > > The usage of threads.h seems to imply we actually want C11 > > _Thread_local. I

Re: [PATCH 2/2] libdw: Rewrite the memory handler to be more robust.

2019-11-08 Thread Mark Wielaard
On Thu, 2019-11-07 at 12:40 -0600, Jonathon Anderson wrote: > I haven't benchmarked this version, but I did benchmark the equivalent > earlier version (this version is almost quite literally a rebase of the > other). I don't have the exact results on hand, what I remember is that > the pthread_k

Re: [PATCH 2/2] libdw: Rewrite the memory handler to be more robust.

2019-11-07 Thread Jonathon Anderson
On Thu, Nov 7, 2019 at 18:20, Mark Wielaard wrote: Hi Jonathan, On Tue, 2019-10-29 at 22:14 +0100, Mark Wielaard wrote: Pthread's thread-local variables are highly limited, which makes it difficult to use many Dwarfs. This replaces that with a less efficient (or elegant) but more robust

Re: [PATCH 2/2] libdw: Rewrite the memory handler to be more robust.

2019-11-07 Thread Jonathon Anderson
On Thu, Nov 7, 2019 at 18:20, Mark Wielaard wrote: Hi Jonathan, On Tue, 2019-10-29 at 22:14 +0100, Mark Wielaard wrote: Pthread's thread-local variables are highly limited, which makes it difficult to use many Dwarfs. This replaces that with a less efficient (or elegant) but more robust

Re: [PATCH 2/2] libdw: Rewrite the memory handler to be more robust.

2019-11-07 Thread Mark Wielaard
Hi Jonathan, On Tue, 2019-10-29 at 22:14 +0100, Mark Wielaard wrote: > Pthread's thread-local variables are highly limited, which makes > it difficult to use many Dwarfs. This replaces that with a > less efficient (or elegant) but more robust method. Thanks, it looks good (similar to a variant I

[PATCH 2/2] libdw: Rewrite the memory handler to be more robust.

2019-10-29 Thread Mark Wielaard
From: Jonathon Anderson Pthread's thread-local variables are highly limited, which makes it difficult to use many Dwarfs. This replaces that with a less efficient (or elegant) but more robust method. Signed-off-by: Jonathon Anderson --- lib/atomics.h | 2 ++ libdw/ChangeLog