Re: [PATCH 15/25] lib: Implement error properly even when not HAVE_ERR_H

2022-12-20 Thread Mark Wielaard
Hi, On Sat, 2022-12-17 at 05:50 +0800, 罗勇刚(Yonggang Luo) wrote: > On Mon, Dec 12, 2022 at 11:37 PM Mark Wielaard > wrote: > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > > wrote: > > > on win32, there is no err.h > > > [...] > > > +#else > > > + (void)status; > > > + vf

Re: [PATCH 15/25] lib: Implement error properly even when not HAVE_ERR_H

2022-12-16 Thread Yonggang Luo
On Mon, Dec 12, 2022 at 11:37 PM Mark Wielaard wrote: > > Hi, > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > wrote: > > on win32, there is no err.h > > [...] > > +#else > > + (void)status; > > + vfprintf(stderr, format, argp); > > +#endif > >va_end(argp); > > That d

Re: [PATCH 15/25] lib: Implement error properly even when not HAVE_ERR_H

2022-12-12 Thread Mark Wielaard
Hi, On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel wrote: > on win32, there is no err.h > [...] > +#else > + (void)status; > + vfprintf(stderr, format, argp); > +#endif >va_end(argp); That doesn't look like a valid implementation of error, it ignores errno and doesn't ex

[PATCH 15/25] lib: Implement error properly even when not HAVE_ERR_H

2022-10-20 Thread Yonggang Luo via Elfutils-devel
on win32, there is no err.h Signed-off-by: Yonggang Luo --- lib/error.c | 9 - lib/system.h | 4 +--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/error.c b/lib/error.c index 5186fc15..7924735e 100644 --- a/lib/error.c +++ b/lib/error.c @@ -28,12 +28,14 @@ #incl