Re: [PATCH 11/16] libdw: Add locking around __libdw_dieabbrev for dwarf_hasattr

2023-10-19 Thread Mark Wielaard
Hi Heather, On Tue, Oct 17, 2023 at 02:57:39PM -0500, Heather McIntyre wrote: > I see now that this is incomplete considering the other places that also > call this function. I do agree that global locking may be heavy if 1) > implemented in all of these locations, or 2) implemented directly in >

Re: [PATCH 11/16] libdw: Add locking around __libdw_dieabbrev for dwarf_hasattr

2023-10-17 Thread Heather McIntyre
Hi Mark, I see now that this is incomplete considering the other places that also call this function. I do agree that global locking may be heavy if 1) implemented in all of these locations, or 2) implemented directly in __libdw_dieabbrev. We could use atomics here directly in __libdw_dieabbrev. I

Re: [PATCH 11/16] libdw: Add locking around __libdw_dieabbrev for dwarf_hasattr

2023-10-11 Thread Mark Wielaard
Hi Heather, On Tue, 2023-10-10 at 15:42 +0200, Mark Wielaard wrote: > From: Heather McIntyre > > * libdw/dwarf_hasattr.c (dwarf_hasattr): Use die_abbrev_lock > around __libdw_dieabbrev call. > > Signed-off-by: Heather S. McIntyre > Signed-off-by: Mark Wielaard > --- > libdw/dwarf

[PATCH 11/16] libdw: Add locking around __libdw_dieabbrev for dwarf_hasattr

2023-10-10 Thread Mark Wielaard
From: Heather McIntyre * libdw/dwarf_hasattr.c (dwarf_hasattr): Use die_abbrev_lock around __libdw_dieabbrev call. Signed-off-by: Heather S. McIntyre Signed-off-by: Mark Wielaard --- libdw/dwarf_hasattr.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libdw/dwarf