Re: [PATCH 1/5] libdwfl: don't bother freeing frames outside of dwfl_thread_getframes

2019-10-29 Thread Mark Wielaard
On Tue, 2019-10-29 at 09:17 -0700, Omar Sandoval wrote: > Unless I missed something, the only place we allocate the state is > from dwfl_thread_getframes, and we always free it before returning from > that function. So if you're not using dwfl_thread_getframes, dwfl_getthreads > won't have anything

Re: [PATCH 1/5] libdwfl: don't bother freeing frames outside of dwfl_thread_getframes

2019-10-29 Thread Omar Sandoval
On Tue, Oct 29, 2019 at 04:55:27PM +0100, Mark Wielaard wrote: > Hi Omar, > > On Mon, 2019-10-07 at 02:05 -0700, Omar Sandoval wrote: > > dwfl_thread_getframes always frees the state before returning, so > > dwfl_getthreads and getthread don't need to do it. > > I am not sure I follow. dwfl_getth

Re: [PATCH 1/5] libdwfl: don't bother freeing frames outside of dwfl_thread_getframes

2019-10-29 Thread Mark Wielaard
Hi Omar, On Mon, 2019-10-07 at 02:05 -0700, Omar Sandoval wrote: > dwfl_thread_getframes always frees the state before returning, so > dwfl_getthreads and getthread don't need to do it. I am not sure I follow. dwfl_getthreads can be used independently from its (indirect) usage from dwfl_thread_ge

[PATCH 1/5] libdwfl: don't bother freeing frames outside of dwfl_thread_getframes

2019-10-07 Thread Omar Sandoval
From: Omar Sandoval dwfl_thread_getframes always frees the state before returning, so dwfl_getthreads and getthread don't need to do it. Signed-off-by: Omar Sandoval --- libdwfl/ChangeLog| 6 ++ libdwfl/dwfl_frame.c | 18 +++--- 2 files changed, 9 insertions(+), 15 deletio