Re: [PATCH 1/2] configure.ac: remove unneeded AC_CONFIG_MACRO_DIR([m4])

2020-12-15 Thread Mark Wielaard
Hi, On Tue, 2020-12-15 at 23:31 +0300, Dmitry V. Levin wrote: > On Tue, Dec 15, 2020 at 03:14:27PM -0500, Frank Ch. Eigler wrote: > > Note that since we do not commit auto*-generated code into the repo, > > we don't really upgrade elfutils autoconf/automake versions. We are > > subject to the whi

Re: [PATCH 1/2] configure.ac: remove unneeded AC_CONFIG_MACRO_DIR([m4])

2020-12-15 Thread Dmitry V. Levin
Hi, On Tue, Dec 15, 2020 at 03:14:27PM -0500, Frank Ch. Eigler wrote: > Hi - > > > I think it is too early to switch to autoconf 2.70. Currently we > > require autoconf 2.63 and automake 1.11. We could probably upgrade to > > autconf 2.69 and automake 1.13, but that doesn't seem to help with > >

Re: [PATCH 1/2] configure.ac: remove unneeded AC_CONFIG_MACRO_DIR([m4])

2020-12-15 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > I think it is too early to switch to autoconf 2.70. Currently we > require autoconf 2.63 and automake 1.11. We could probably upgrade to > autconf 2.69 and automake 1.13, but that doesn't seem to help with > AC_CONFIG_MACRO_DIR/ACLOCAL_AMFLAGS. > > Since AC_CONFIG_MACRO_DIR is deprecated i

Re: [PATCH 1/2] configure.ac: remove unneeded AC_CONFIG_MACRO_DIR([m4])

2020-12-15 Thread Mark Wielaard
Hi Dmitry, On Tue, 2020-12-15 at 20:01 +0300, Dmitry V. Levin wrote: > Hmm, despite all these recommendation, virtually every project that > uses > automake also uses ACLOCAL_AMFLAGS, and very few use > AC_CONFIG_MACRO_DIR. > > The documentation on AC_CONFIG_MACRO_DIR says that > "you must also s

Re: [PATCH 1/2] configure.ac: remove unneeded AC_CONFIG_MACRO_DIR([m4])

2020-12-15 Thread Dmitry V. Levin
On Tue, Dec 15, 2020 at 04:07:02PM +0100, Mark Wielaard wrote: > On Tue, 2020-12-15 at 17:40 +0300, Dmitry V. Levin wrote: > > Makefile.am already contains "ACLOCAL_AMFLAGS = -I m4", > > that is enough for autoreconf to do the right thing. > > But is that a good thing to rely on? Looks like that'

Re: [PATCH 1/2] configure.ac: remove unneeded AC_CONFIG_MACRO_DIR([m4])

2020-12-15 Thread Mark Wielaard
On Tue, 2020-12-15 at 17:40 +0300, Dmitry V. Levin wrote: > Makefile.am already contains "ACLOCAL_AMFLAGS = -I m4", > that is enough for autoreconf to do the right thing. But is that a good thing to rely on? The autoconf manual says "be aware that future Automake releases might start flagging ACL

[PATCH 1/2] configure.ac: remove unneeded AC_CONFIG_MACRO_DIR([m4])

2020-12-15 Thread Dmitry V. Levin
Makefile.am already contains "ACLOCAL_AMFLAGS = -I m4", that is enough for autoreconf to do the right thing. Tested with autoreconf -if && ./configure --enable-maintainer-mode && make && make distcheck Signed-off-by: Dmitry V. Levin --- ChangeLog| 4 configure.ac | 1 - 2 files changed