Re: [PATCH 08/15] dwarf_offdie.c: Add locking

2025-01-23 Thread Aaron Merey
Hi Mark, On Wed, Jan 22, 2025 at 7:12 PM Mark Wielaard wrote: > > On Sun, Jan 19, 2025 at 10:20:34PM -0500, Aaron Merey wrote: > > * libdw/dwarf_offdie.c (__libdw_offdie): Use dwarf_lock. > > What exactly is "protected" here? If it is just the __libdw_findcu > call, then it seems the lock

Re: [PATCH 08/15] dwarf_offdie.c: Add locking

2025-01-22 Thread Mark Wielaard
Hi Aaron, On Sun, Jan 19, 2025 at 10:20:34PM -0500, Aaron Merey wrote: > * libdw/dwarf_offdie.c (__libdw_offdie): Use dwarf_lock. What exactly is "protected" here? If it is just the __libdw_findcu call, then it seems the lock is too wide/early. It could just be taken just before that call,

[PATCH 08/15] dwarf_offdie.c: Add locking

2025-01-19 Thread Aaron Merey
* libdw/dwarf_offdie.c (__libdw_offdie): Use dwarf_lock. Signed-off-by: Aaron Merey --- libdw/dwarf_offdie.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libdw/dwarf_offdie.c b/libdw/dwarf_offdie.c index 883720de..74eac420 100644 --- a/libdw/dwarf_offdie.c +++ b/libdw/dwarf_of