Re: [PATCH 05/15] dwarf_getsrclines.c: Add locking

2025-01-23 Thread Aaron Merey
Hi Mark, On Wed, Jan 22, 2025 at 6:35 PM Mark Wielaard wrote: > > On Sun, Jan 19, 2025 at 10:20:31PM -0500, Aaron Merey wrote: > >else if (cu->lines == (void *) -1l) > > return -1; > > Aren't we still holding the lock here? You're right, will fix in v2. Aaron

Re: [PATCH 05/15] dwarf_getsrclines.c: Add locking

2025-01-22 Thread Mark Wielaard
On Sun, Jan 19, 2025 at 10:20:31PM -0500, Aaron Merey wrote: > * libdw/dwarf_getsrclines.c (dwarf_getsrclines): Use dwarf_lock. So same lock used for getting/setting Dwarf_Lines. It is a little unfortunate that lines and files table reading is so intertwined. I understand why you use the sa

[PATCH 05/15] dwarf_getsrclines.c: Add locking

2025-01-19 Thread Aaron Merey
* libdw/dwarf_getsrclines.c (dwarf_getsrclines): Use dwarf_lock. Signed-off-by: Aaron Merey --- libdw/dwarf_getsrclines.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/libdw/dwarf_getsrclines.c b/libdw/dwarf_getsrclines.c index da78db67..fb2c