Re: [PATCH 05/14] libdw: Fix dwarf_macro_getsrcfiles for DWARF 5

2023-10-03 Thread Mark Wielaard
Hi Omar, On Wed, Sep 27, 2023 at 11:20:54AM -0700, Omar Sandoval wrote: > Dwarf_Macro_Op_Table::is_64bit conflates the address size and the offset > size: for .debug_macinfo, it is initialized based on the compilation > unit's address size, but for .debug_macro, it is initialized based on > the ma

[PATCH 05/14] libdw: Fix dwarf_macro_getsrcfiles for DWARF 5

2023-09-27 Thread Omar Sandoval
From: Omar Sandoval Dwarf_Macro_Op_Table::is_64bit conflates the address size and the offset size: for .debug_macinfo, it is initialized based on the compilation unit's address size, but for .debug_macro, it is initialized based on the macro unit's offset size. is_64bit is used to determine the