Re: [PATCH 03/16] libelf: Fix deadlock in __libelf_readall

2023-11-09 Thread Mark Wielaard
Hi Heather, On Tue, 2023-10-17 at 14:11 -0500, Heather McIntyre wrote: > I will push the changes after I am done testing other fixes > since I want to ensure that everything works together cohesively.  Please let us know if we can help update your patches. I realize we have been patching some of

Re: [PATCH 03/16] libelf: Fix deadlock in __libelf_readall

2023-10-17 Thread Heather McIntyre
You are right that if elf->map_address != NULL then the acquired wrlock is not unlocked. The rwlock_unlock that was there initially was removed due to deadlocking when returning from inside the if statement, but this was not correct. However, adding ‘else rwlock_unlock (elf->lock)’ at the end of th

Re: [PATCH 03/16] libelf: Fix deadlock in __libelf_readall

2023-10-10 Thread Mark Wielaard
Hi Heather, On Tue, 2023-10-10 at 15:42 +0200, Mark Wielaard wrote: > From: Heather McIntyre > > * libelf/elf_readall.c (__libelf_readall): Move rwlock_unlock > before libelf_acquire_all. > > Signed-off-by: Heather S. McIntyre > Signed-off-by: Mark Wielaard > --- > libelf/elf_rea

[PATCH 03/16] libelf: Fix deadlock in __libelf_readall

2023-10-10 Thread Mark Wielaard
From: Heather McIntyre * libelf/elf_readall.c (__libelf_readall): Move rwlock_unlock before libelf_acquire_all. Signed-off-by: Heather S. McIntyre Signed-off-by: Mark Wielaard --- libelf/elf_readall.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib