Re: [PATCH 02/14] libdw: Handle split DWARF in dwarf_entrypc

2023-10-03 Thread Mark Wielaard
Hi Omar, On Wed, 2023-09-27 at 11:20 -0700, Omar Sandoval wrote: > From: Omar Sandoval > > If a DIE has no DW_AT_entry_pc attribute, dwarf_entrypc looks for > DW_AT_low_pc in that DIE. But for a split compilation unit DIE, > DW_AT_low_pc is in the corresponding skeleton DIE, so this fails. > dw

[PATCH 02/14] libdw: Handle split DWARF in dwarf_entrypc

2023-09-27 Thread Omar Sandoval
From: Omar Sandoval If a DIE has no DW_AT_entry_pc attribute, dwarf_entrypc looks for DW_AT_low_pc in that DIE. But for a split compilation unit DIE, DW_AT_low_pc is in the corresponding skeleton DIE, so this fails. dwarf_lowpc already handles this fallback, so use it instead. Signed-off-by: Om