Re: [PATCH] unstrip: Call adjust_relocs no more than once per section.

2024-02-06 Thread Aaron Merey
Hi Mark, On Tue, Feb 6, 2024 at 10:36 AM Mark Wielaard wrote: > > So it looks like elfcmp explicitly checks ebl_section_strip_p and > doesn't compare sections that are strippable. Maybe we should add an > eu-elfcmp --all-sections flag? > > We should probably also check that it handles the new SHT

Re: [PATCH] unstrip: Call adjust_relocs no more than once per section.

2024-02-06 Thread Mark Wielaard
Hi Aaron, On Mon, 2024-02-05 at 18:11 -0500, Aaron Merey wrote: > During symtab merging, adjust_relocs might be called multiple times on > some SHT_REL/SHT_RELA sections. In these cases it is possible for a > relocation's symbol index to be correctly mapped from X to Y during the > first call to

[PATCH] unstrip: Call adjust_relocs no more than once per section.

2024-02-05 Thread Aaron Merey
During symtab merging, adjust_relocs might be called multiple times on some SHT_REL/SHT_RELA sections. In these cases it is possible for a relocation's symbol index to be correctly mapped from X to Y during the first call to adjust_relocs but then wrongly remapped from Y to Z during the second cal