Re: [PATCH] strip, unstrip: Handle SHT_GROUP correctly.

2018-10-19 Thread Mark Wielaard
After a bit more testing found one other issue. It can happen that the section indexes in the group need to be renumbered when eu-unstrip puts the stripped and debug file together again. So we need to explicitly do that.commit eee4269e53154daaf0251371aacd91ec5db3eb30 Author: Mark Wielaard Date:

Re: [PATCH] strip, unstrip: Handle SHT_GROUP correctly.

2018-10-17 Thread Mark Wielaard
On Sat, 2018-10-13 at 10:46 +0200, Mark Wielaard wrote: > The usage of annobin in Fedora showed a couple of bugs when using > eu-strip and eu-unstrip on ET_REL files that contain multiple group > sections. > > When stripping we should not remove the SHF_GROUP flag from sections > even if the group

[PATCH] strip, unstrip: Handle SHT_GROUP correctly.

2018-10-13 Thread Mark Wielaard
The usage of annobin in Fedora showed a couple of bugs when using eu-strip and eu-unstrip on ET_REL files that contain multiple group sections. When stripping we should not remove the SHF_GROUP flag from sections even if the group section itself might be removed. Either the section itself gets rem