Re: [PATCH] src/readelf.c: Close skel_fd

2025-01-25 Thread Mark Wielaard
Hi Aaron, On Fri, Jan 24, 2025 at 08:32:58PM -0500, Aaron Merey wrote: > skel_fd is passed to create_dwfl, which calls dup() on skel_fd. > create_dwfl handles closing the dup'ed fd but not the original. > > Ensure the original skel_fd is closed after it's passed to create_dwfl. Nice find. We sh

[PATCH] src/readelf.c: Close skel_fd

2025-01-24 Thread Aaron Merey
skel_fd is passed to create_dwfl, which calls dup() on skel_fd. create_dwfl handles closing the dup'ed fd but not the original. Ensure the original skel_fd is closed after it's passed to create_dwfl. Signed-off-by: Aaron Merey --- src/readelf.c | 8 +++- 1 file changed, 7 insertions(+), 1 d