Re: [PATCH] libelf/elf_end.c: check data_list.data.d.d_buf before free it

2018-08-20 Thread Robert Yang
On 08/17/2018 06:10 PM, Mark Wielaard wrote: Hi Robert, [I don't have very good internet connectivity so cannot easily get all the bits and sources to replicate/inspect. So apologies if I am misinterpreting something.] On Fri, Aug 17, 2018 at 04:25:07PM +0800, Robert Yang wrote: On 08/1

Re: [PATCH] libelf/elf_end.c: check data_list.data.d.d_buf before free it

2018-08-17 Thread Mark Wielaard
Hi Robert, [I don't have very good internet connectivity so cannot easily get all the bits and sources to replicate/inspect. So apologies if I am misinterpreting something.] On Fri, Aug 17, 2018 at 04:25:07PM +0800, Robert Yang wrote: > On 08/17/2018 03:25 AM, Mark Wielaard wrote: > > On Thu, A

Re: [PATCH] libelf/elf_end.c: check data_list.data.d.d_buf before free it

2018-08-17 Thread Jan Pokorný
[rereading, two prelink commands got missing and diff ones were garbled in the sequence below, losing consequentiality, sorry] On 16/08/18 22:15 +0200, Jan Pokorný wrote: > Out of curiousity, tried this on my Fedora machine without any > success to reproduce: > > # dnf install -y libqb > https

Re: [PATCH] libelf/elf_end.c: check data_list.data.d.d_buf before free it

2018-08-17 Thread Robert Yang
On 08/17/2018 03:25 AM, Mark Wielaard wrote: Hi, On Thu, Aug 16, 2018 at 10:34:23AM +0800, Robert Yang wrote: The one which actually saves the data is data_list.data.d.d_buf, so check it before free rawdata_base. This can fix a segmentation fault when prelink libqb_1.0.3: prelink: /usr/lib/

Re: [PATCH] libelf/elf_end.c: check data_list.data.d.d_buf before free it

2018-08-16 Thread Jan Pokorný
On 16/08/18 21:25 +0200, Mark Wielaard wrote: > On Thu, Aug 16, 2018 at 10:34:23AM +0800, Robert Yang wrote: >> The one which actually saves the data is data_list.data.d.d_buf, so check it >> before free rawdata_base. >> >> This can fix a segmentation fault when prelink libqb_1.0.3: >> prelink: /u

Re: [PATCH] libelf/elf_end.c: check data_list.data.d.d_buf before free it

2018-08-16 Thread Mark Wielaard
Hi, On Thu, Aug 16, 2018 at 10:34:23AM +0800, Robert Yang wrote: > The one which actually saves the data is data_list.data.d.d_buf, so check it > before free rawdata_base. > > This can fix a segmentation fault when prelink libqb_1.0.3: > prelink: /usr/lib/libqb.so.0.18.2: Symbol section index out

[PATCH] libelf/elf_end.c: check data_list.data.d.d_buf before free it

2018-08-15 Thread Robert Yang
The one which actually saves the data is data_list.data.d.d_buf, so check it before free rawdata_base. This can fix a segmentation fault when prelink libqb_1.0.3: prelink: /usr/lib/libqb.so.0.18.2: Symbol section index outside of section numbers The segmentation fault happens when prelink call e