Re: [PATCH] libdw: dwarf_getsrcfiles should not imply dwarf_getsrclines

2024-04-11 Thread Aaron Merey
On Thu, Apr 11, 2024 at 5:55 AM Mark Wielaard wrote: > > All looks good BTW. Please do push (if possible with the above change). Thanks Mark, pushed as commit d4b0848be5f575ff9464fee12ce7be416e4fb392 Aaron

Re: [PATCH] libdw: dwarf_getsrcfiles should not imply dwarf_getsrclines

2024-04-11 Thread Mark Wielaard
Hi Aaron, On Wed, Apr 10, 2024 at 04:43:53PM -0400, Aaron Merey wrote: > > > - /* Pass the file data structure to the caller. */ > > > - if (filesp != NULL) > > > -*filesp = files; > > > + const char **newdirs = (void *) &newfiles->info[nnewfiles]; > > > + const char **prevdirs =

Re: [PATCH] libdw: dwarf_getsrcfiles should not imply dwarf_getsrclines

2024-04-10 Thread Aaron Merey
Hi Mark, On Wed, Apr 10, 2024 at 3:48 PM Mark Wielaard wrote: > > v2 changes: > > Restored support for DW_LNE_define_file. > > Great. And sorry I first suggested to just drop it and then said I > would like it back. This was more work than I though. No problem, better if we support this just in

Re: [PATCH] libdw: dwarf_getsrcfiles should not imply dwarf_getsrclines

2024-04-10 Thread Mark Wielaard
Hi Aaron, On Tue, 2024-04-09 at 23:45 -0400, Aaron Merey wrote: > dwarf_getsrcfiles causes line data to be read in addition to file data. > This is wasteful for programs which only need file or directory names. > Debuginfod server is one such example. > > Fix this by moving the srcfile reading in

[PATCH] libdw: dwarf_getsrcfiles should not imply dwarf_getsrclines

2024-04-09 Thread Aaron Merey
dwarf_getsrcfiles causes line data to be read in addition to file data. This is wasteful for programs which only need file or directory names. Debuginfod server is one such example. Fix this by moving the srcfile reading in read_srclines into a separate function read_srcfiles. This change improve

Re: [PATCH] libdw: dwarf_getsrcfiles should not imply dwarf_getsrclines

2024-04-02 Thread Mark Wielaard
Hi Aaron, On Thu, 2024-03-28 at 21:12 -0400, Aaron Merey wrote: > dwarf_getsrcfiles causes line data to be read in addition to file data. > This is wasteful for programs which only need file or directory names. > Debuginfod server is one such example. > > Fix this by moving the srcfile handling i

[PATCH] libdw: dwarf_getsrcfiles should not imply dwarf_getsrclines

2024-03-28 Thread Aaron Merey
dwarf_getsrcfiles causes line data to be read in addition to file data. This is wasteful for programs which only need file or directory names. Debuginfod server is one such example. Fix this by moving the srcfile handling in read_srclines into a separate function read_srcfiles. read_srclines also