Re: [PATCH] lib: sha1, md5, use memmove to move bytes inside buffer, not memcpy.

2017-10-16 Thread Mark Wielaard
On Mon, 2017-10-16 at 13:00 +0200, Mark Wielaard wrote: > At the end of {sha1,md5}_process_bytes we move the contents of > ctx->buffer up to the start of the buffer. Since this means the > source and destination overlap we should use memmove, not memcpy. I am retracting this patch since I noticed

[PATCH] lib: sha1, md5, use memmove to move bytes inside buffer, not memcpy.

2017-10-16 Thread Mark Wielaard
At the end of {sha1,md5}_process_bytes we move the contents of ctx->buffer up to the start of the buffer. Since this means the source and destination overlap we should use memmove, not memcpy. Signed-off-by: Mark Wielaard --- lib/ChangeLog | 6 ++ lib/md5.c | 2 +- lib/sha1.c| 2 +-