Re: [PATCH] elflint: Always print symbol name (if known) in error messages.

2020-12-15 Thread Dmitry V. Levin
Hi Mark, On Tue, Dec 15, 2020 at 11:53:48PM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Wed, Dec 16, 2020 at 12:44:05AM +0300, Dmitry V. Levin wrote: > > This is nice, thanks. > > I have one question about the patch: > > > > [...] > > > --- a/src/elflint.c > > > +++ b/src/elflint.c > > > @@

Re: [PATCH] elflint: Always print symbol name (if known) in error messages.

2020-12-15 Thread Mark Wielaard
Hi Dmitry, On Wed, Dec 16, 2020 at 12:44:05AM +0300, Dmitry V. Levin wrote: > This is nice, thanks. > I have one question about the patch: > > [...] > > --- a/src/elflint.c > > +++ b/src/elflint.c > > @@ -706,7 +706,7 @@ section [%2d] '%s': XINDEX for zeroth entry not > > zero\n"), > > con

Re: [PATCH] elflint: Always print symbol name (if known) in error messages.

2020-12-15 Thread Dmitry V. Levin
On Tue, Dec 15, 2020 at 09:52:40PM +0100, Mark Wielaard wrote: > Adding the symbol name associated with the symbol index number > makes the error messages a little bit more useful. We used to say: > > section [59] '.symtab': symbol 9: st_value out of bounds > > But now says: > > section [59] '.s

[PATCH] elflint: Always print symbol name (if known) in error messages.

2020-12-15 Thread Mark Wielaard
Adding the symbol name associated with the symbol index number makes the error messages a little bit more useful. We used to say: section [59] '.symtab': symbol 9: st_value out of bounds But now says: section [59] '.symtab': symbol 9 (.annobin_size.c.hot): st_value out of bounds Signed-off-by: