Re: [PATCH] elfcompress: Swap fchmod and fchown calls on new file.

2018-07-22 Thread Mark Wielaard
On Sat, Jul 21, 2018 at 05:05:43PM +0200, Igor Gnatenko wrote: > On Sat, Jul 21, 2018 at 4:56 PM Mark Wielaard wrote: > > > Calling fchmod with a suid bit on a file might silently fail or the suid > > bit might be slilently cleared by a call to fchown if already set. Swap > > the calls so that th

[PATCH] elfcompress: Swap fchmod and fchown calls on new file.

2018-07-21 Thread Mark Wielaard
Calling fchmod with a suid bit on a file might silently fail or the suid bit might be slilently cleared by a call to fchown if already set. Swap the calls so that the owner is set first and then set the suid bit. https://bugzilla.redhat.com/show_bug.cgi?id=1607044 Signed-off-by: Mark Wielaard --