Hi Mark,
On Wed, Oct 26, 2022 at 11:06 AM Mark Wielaard wrote:
> On Mon, 2022-10-24 at 14:38 -0400, Frank Ch. Eigler via Elfutils-devel
> wrote:
> > - not sure I understand why the code worries about dots in or not in
> > section names. Why not just pass them verbatim throughout the code
> >
Hi Frank,
On Mon, Oct 24, 2022 at 2:38 PM Frank Ch. Eigler wrote:
> - use of write(2) to put files onto disk is not quite right; write(2) can
> be partial, so you need a loop (or a macro wrapping a loop)
Fixed.
> - not sure I understand why the code worries about dots in or not in
> section
Hi -
> Is/should the section name be URL-encoded?
Yes!
> I would drop the maybe_debuginfo_section heuristics. There are some
> sections like .strtab/.symtab that are probably in the debug file, but
> might be in the executable. I would assume that a named section can
> normally be found in the d
Hi,
On Mon, 2022-10-24 at 14:38 -0400, Frank Ch. Eigler via Elfutils-devel
wrote:
> - use of write(2) to put files onto disk is not quite right; write(2)
> can
> be partial, so you need a loop (or a macro wrapping a loop)
Since debuginfod-client.c already includes system.h it can use:
static i
Hi,
On Mon, 2022-10-24 at 14:38 -0400, Frank Ch. Eigler via Elfutils-devel
wrote:
> - not sure I understand why the code worries about dots in or not in
> section names. Why not just pass them verbatim throughout the code
> base, and not worry about whether or not there's a dot? Does the
>
Hi -
Generally looks fine, thanks a lot.
A few nits:
- use of write(2) to put files onto disk is not quite right; write(2) can
be partial, so you need a loop (or a macro wrapping a loop)
- not sure I understand why the code worries about dots in or not in
section names. Why not just pass th
I'm resending this patch with a small modification. I added a new
field "progressfn_cancel" to debuginfod_client that indicates whether
the most recent query was cancelled due to progressfn returning 1.
If a server doesn't support section queries and the client begins
downloading a debuginfo or e
Hi Frank,
On Wed, Sep 28, 2022 at 10:28 AM Frank Ch. Eigler wrote:
> On Tue, Sep 27, 2022 at 10:10:52PM -0400, Aaron Merey via Elfutils-devel
> wrote:
>
> > [...] In order to distinguish between debuginfo and executable
> > files with the same build-id, this function includes a bool
> > paramet
Hi, Aaron -
On Tue, Sep 27, 2022 at 10:10:52PM -0400, Aaron Merey via Elfutils-devel wrote:
> [...] In order to distinguish between debuginfo and executable
> files with the same build-id, this function includes a bool
> parameter use_debuginfo. If true, attempt to retrieve the section
> from t
This patch adds a new function debuginfod_find_section which queries
debuginfod servers for the binary contents of the specified ELF/DWARF
section in a file matching the given build-id.
In order to distinguish between debuginfo and executable files with the
same build-id, this function includes a
10 matches
Mail list logo
