Re: [PATCH] configure: Add new --enable-install-elfh option.

2019-01-31 Thread Mark Wielaard
On Wed, Jan 30, 2019 at 09:54:53AM +, Ulf Hermann wrote: > > Yes, it should indeed. > > I used a slightly different solution though. > > It relies on the default include flags already including the srcdirs. > > Does that work for your use case too? (See revised patch attached.) > > I'm not an

Re: [PATCH] configure: Add new --enable-install-elfh option.

2019-01-30 Thread Ulf Hermann
> Yes, it should indeed. > I used a slightly different solution though. > It relies on the default include flags already including the srcdirs. > Does that work for your use case too? (See revised patch attached.) I'm not an expert in autotools. The reason I also have "else" case in my code is th

Re: [PATCH] configure: Add new --enable-install-elfh option.

2019-01-29 Thread Mark Wielaard
I am not sure it really should define uid_t, > gid_t, mode_t, and pid_t. Those normally don't come from features.h > (they would come from sys/types.h). Thanks, Mark > From 86f9481187bccb78b2533674bb905a0de1a03abf Mon Sep 17 00:00:00 2001 > From: Mark Wielaard > Date: Fri, 1

Re: [PATCH] configure: Add new --enable-install-elfh option.

2019-01-24 Thread Mark Wielaard
From: Mark Wielaard Date: Fri, 18 Jan 2019 14:18:22 +0100 Subject: [PATCH] configure: Add new --enable-install-elfh option. We explicitly test (with system-elf-libelf) that our include headers work with the system elf.h header. But it might be helpful to install the elf.h file for a private insta

Re: [PATCH] configure: Add new --enable-install-elfh option.

2019-01-18 Thread Ulf Hermann
I think you should also adapt tests/Makefile.am to use our own elf.h in this case. See https://codereview.qt-project.org/#/c/187812/25 for my solution to this.

[PATCH] configure: Add new --enable-install-elfh option.

2019-01-18 Thread Mark Wielaard
We explicitly test (with system-elf-libelf) that our include headers work with the system elf.h header. But it might be helpful to install the elf.h file for a private install. Our elf.h header really is just a copy of the latest glibc elf.h. But it might be newer and include more constants than th