Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-09 Thread Mark Wielaard
Hi Dmitry, On Mon, 2020-11-02 at 08:00 +, Dmitry V. Levin wrote: > When elfutils is configured using --enable-libdebuginfod > --disable-debuginfod, that is, when the library is built and > installed > but the server is not, it makes sense to install libdebuginfod.pc > because the latter comple

Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-04 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > Something like this? > -DEBUGINFOD_URLS="$DEBUGINFOD_URLS @DEBUGINFOD_URLS@" > -export DEBUGINFOD_URLS > +if [ -n "@DEBUGINFOD_URLS@" ]; then > + DEBUGINFOD_URLS="${DEBUGINFOD_URLS-}${DEBUGINFOD_URLS:+ > }@DEBUGINFOD_URLS@" > + export DEBUGINFOD_URLS > +fi You took the words righ

Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-03 Thread Dmitry V. Levin
Hi, On Tue, Nov 03, 2020 at 06:26:07PM +0100, Mark Wielaard wrote: > Hi Frank, > > On Tue, 2020-11-03 at 12:07 -0500, Frank Ch. Eigler via Elfutils-devel > wrote: > > > While packaging I noticed that we install the profiles.d files even > > > when the DEBUGINFOD_URLS is empty. I think we should a

Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-03 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > That is a good point. But I think the default setting is wrong if it > isn't actually used/setup. As the profile shell snippets are now they > define the DEBUGINFOD_URLS environment variable as an non-empty string > (although just containing spaces), [...] Good point, we should make it emp

Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-03 Thread Mark Wielaard
Hi Frank, On Tue, 2020-11-03 at 12:07 -0500, Frank Ch. Eigler via Elfutils-devel wrote: > > While packaging I noticed that we install the profiles.d files even > > when the DEBUGINFOD_URLS is empty. I think we should avoid that. > > I think we should install them anyway. They give a sysadmin an

Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-03 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > While packaging I noticed that we install the profiles.d files even > when the DEBUGINFOD_URLS is empty. I think we should avoid that. I think we should install them anyway. They give a sysadmin an easy knob to set a systemwide default, even if the distro build didn't. - FChE

Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-03 Thread Mark Wielaard
Hi Dmitry, On Mon, 2020-11-02 at 08:00 +, Dmitry V. Levin wrote: > When elfutils is configured using --enable-libdebuginfod > --disable-debuginfod, that is, when the library is built and installed > but the server is not, it makes sense to install libdebuginfod.pc > because the latter compleme

[PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-02 Thread Dmitry V. Levin
When elfutils is configured using --enable-libdebuginfod --disable-debuginfod, that is, when the library is built and installed but the server is not, it makes sense to install libdebuginfod.pc because the latter complements the library rather than the server. Likewise, it makes sense to install p