Re: [PATCH] Prevent binaries in src from colliding with libc++ headers

2024-08-14 Thread Aaron Merey
Hi Tristan, On Fri, Aug 9, 2024 at 10:43 AM Tristan ross wrote: > > Well, that's great. Probably should use it instead since it's simpler. > > 日付:Fri, 09 Aug 2024 07:38:05 -0700 差出人:ame...@redhat.com > > (elfutils-devel CC'ed) > > On Fri, Aug 9, 2024 at 10:32 AM Tristan ross > wrote:

Re: [PATCH] Prevent binaries in src from colliding with libc++ headers

2024-08-09 Thread Aaron Merey
(elfutils-devel CC'ed) On Fri, Aug 9, 2024 at 10:32 AM Tristan ross wrote: > > The Gentoo patch looks essentially the same as what we started with which > might bring that warning back. It also uses `-iquote .` but from what I've > seen, no files in src import with quotes. But that patch will w

Re: [PATCH] Prevent binaries in src from colliding with libc++ headers

2024-08-09 Thread Aaron Merey
Hi Tristan, (elfutils-devel CC'ed) On Thu, Aug 8, 2024 at 6:09 PM Tristan ross wrote: > > > Can you also provide a reproducer for the error you are seeing? > > I think this can be reproduced if you build elfutils with Clang and Clang is > using libc++ (LLVM's C++ implementation). Build with lik

Re: [PATCH] Prevent binaries in src from colliding with libc++ headers

2024-08-08 Thread Aaron Merey
Hi Tristan, On Thu, Aug 8, 2024 at 2:19 PM Aaron Merey wrote: > On Wed, Aug 7, 2024 at 5:07 PM Tristan ross wrote: > > > > Gotcha on that ChangeLog thing. With the warning, I think we can just > > use `?=` in `config/eu.am` for `AM_CPPFLAGS`. > > I tried this but I still got an error during auto

Re: [PATCH] Prevent binaries in src from colliding with libc++ headers

2024-08-08 Thread Aaron Merey
From: Tristan Ross Hi Tristan On Wed, Aug 7, 2024 at 5:07 PM Tristan ross wrote: > > Gotcha on that ChangeLog thing. With the warning, I think we can just > use `?=` in `config/eu.am` for `AM_CPPFLAGS`. I tried this but I still got an error during autoreconf. I tweaked your patch below so tha

Re: [PATCH] Prevent binaries in src from colliding with libc++ headers

2024-08-07 Thread Aaron Merey
Hi Tristan, Thanks for the patch, some comments below. > From 11f000782c16f05f81a15d4dba75deb082ab97e1 Mon Sep 17 00:00:00 2001 > From: Tristan Ross > Date: Tue, 30 Jul 2024 21:03:03 -0700 > Subject: [PATCH] Prevent binaries in src from colliding with libc++ headers > > Disco

[PATCH] Prevent binaries in src from colliding with libc++ headers

2024-07-30 Thread Tristan ross
Discovered with Nix and LLVM 17. Headers inside of libc++ can easily collide with binaries being linked in src. This results in clang trying to include a binary as a header. 0001-Prevent-binaries-in-src-from-colliding-with-libc-hea.patch Description: Binary data