Re: [PATCH] On elf_update, remember when we mmap()

2017-04-28 Thread Ulf Hermann
On 04/28/2017 12:23 AM, Mark Wielaard wrote: > On Thu, Apr 20, 2017 at 04:57:41PM +0200, Ulf Hermann wrote: >> Otherwise we skip the munmap() later. This leaks resources. > > Oops. Good find. Applied to master. > > When configured --with-valgrind the tests are run under valgrind > and memory leak

Re: [PATCH] On elf_update, remember when we mmap()

2017-04-27 Thread Mark Wielaard
On Thu, Apr 20, 2017 at 04:57:41PM +0200, Ulf Hermann wrote: > Otherwise we skip the munmap() later. This leaks resources. Oops. Good find. Applied to master. When configured --with-valgrind the tests are run under valgrind and memory leaks will fail the tests. But since this is mmap valgrind won

[PATCH] On elf_update, remember when we mmap()

2017-04-20 Thread Ulf Hermann
Otherwise we skip the munmap() later. This leaks resources. Signed-off-by: Ulf Hermann --- libelf/ChangeLog| 4 libelf/elf_update.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/libelf/ChangeLog b/libelf/ChangeLog index fa768f8..225c7c8 100644 --- a/libelf/ChangeLog +++ b/libel