Re: [PATCH] Fix bug in read_3ubyte_unaligned_inc

2020-10-29 Thread Mark Wielaard
On Thu, 2020-10-29 at 13:36 -0600, Tom Tromey wrote: > > > > > > "Mark" == Mark Wielaard writes: > > Mark> On Sat, Oct 24, 2020 at 03:05:55PM -0600, Tom Tromey wrote: > Mark> Clearly DW_FORM_strx3 and DW_FORM_addrx3 aren't used much > Mark> (given that it is an index value between larger than 655

Re: [PATCH] Fix bug in read_3ubyte_unaligned_inc

2020-10-29 Thread Tom Tromey
> "Mark" == Mark Wielaard writes: Mark> On Sat, Oct 24, 2020 at 03:05:55PM -0600, Tom Tromey wrote: Mark> Clearly DW_FORM_strx3 and DW_FORM_addrx3 aren't used much Mark> (given that it is an index value between larger than 65536). >> >> I don't even really see the need for a 3-byte form. >>

Re: [PATCH] Fix bug in read_3ubyte_unaligned_inc

2020-10-25 Thread Mark Wielaard
On Sat, Oct 24, 2020 at 03:05:55PM -0600, Tom Tromey wrote: > Mark> Clearly DW_FORM_strx3 and DW_FORM_addrx3 aren't used much > Mark> (given that it is an index value between larger than 65536). > > I don't even really see the need for a 3-byte form. > Anyway if it helps, gdb gets this wrong too -

Re: [PATCH] Fix bug in read_3ubyte_unaligned_inc

2020-10-24 Thread Tom Tromey
Mark> Clearly DW_FORM_strx3 and DW_FORM_addrx3 aren't used much Mark> (given that it is an index value between larger than 65536). I don't even really see the need for a 3-byte form. Anyway if it helps, gdb gets this wrong too -- gdb always uses little-endian, which seems wrong, but I didn't know

Re: [PATCH] Fix bug in read_3ubyte_unaligned_inc

2020-10-24 Thread Mark Wielaard
On Fri, Oct 23, 2020 at 04:51:10PM -0600, Tom Tromey wrote: > The read_3ubyte_unaligned_inc macro calls read_2ubyte_unaligned, but > it should call read_3ubyte_unaligned. Eep. And read_3ubyte_unaligned is actually is tricky to get right if you want to correctly read 3-byte unsigned integers given

[PATCH] Fix bug in read_3ubyte_unaligned_inc

2020-10-23 Thread Tom Tromey
The read_3ubyte_unaligned_inc macro calls read_2ubyte_unaligned, but it should call read_3ubyte_unaligned. Signed-off-by: Tom Tromey --- libdw/ChangeLog | 5 + libdw/memory-access.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libdw/ChangeLog b/libdw/ChangeLog