Re: [PATCH] Avoid signed/unsigned comparison

2017-04-27 Thread Josh Stone
On 04/27/2017 11:24 AM, Mark Wielaard wrote: > On Thu, Apr 20, 2017 at 04:40:30PM +0200, Ulf Hermann wrote: >> Some compilers implicitly cast the result of uint_fast16_t * >> uint_fast16_t to something signed and then complain about the >> comparison to (unsigned) size_t. > > Really? That is allow

Re: [PATCH] Avoid signed/unsigned comparison

2017-04-27 Thread Mark Wielaard
On Thu, Apr 20, 2017 at 04:40:30PM +0200, Ulf Hermann wrote: > Some compilers implicitly cast the result of uint_fast16_t * > uint_fast16_t to something signed and then complain about the > comparison to (unsigned) size_t. Really? That is allowed? Using a signed type for uint_fast16_t? > Casting

[PATCH] Avoid signed/unsigned comparison

2017-04-20 Thread Ulf Hermann
Some compilers implicitly cast the result of uint_fast16_t * uint_fast16_t to something signed and then complain about the comparison to (unsigned) size_t. Casting phnum to size_t is a good idea anyway as 16bit multiplication can easily overflow and we are not checking for this. Signed-off-by: Ul