Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.

2017-07-17 Thread Mark Wielaard
On Tue, Jul 18, 2017 at 01:24:46AM +0300, Dmitry V. Levin wrote: > I reviewed and approved both of these commits assuming that they brought > no regressions. If sys/ptrace.h from glibc 2.25 could be included before > or after linux/ptrace.h, this shouldn't have changed in glibc 2.26. > > In other

Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.

2017-07-17 Thread Dmitry V. Levin
On Mon, Jul 17, 2017 at 06:41:47PM +0200, Mark Wielaard wrote: > On Mon, 2017-07-17 at 19:29 +0300, Dmitry V. Levin wrote: > > On Mon, Jul 17, 2017 at 05:44:54PM +0200, Mark Wielaard wrote: > > > glibc 2.26 changed the sys/ptrace.h header so that it cannot be included > > > after asm/ptrace.h. We s

Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.

2017-07-17 Thread Mark Wielaard
On Mon, 2017-07-17 at 19:29 +0300, Dmitry V. Levin wrote: > On Mon, Jul 17, 2017 at 05:44:54PM +0200, Mark Wielaard wrote: > > glibc 2.26 changed the sys/ptrace.h header so that it cannot be included > > after asm/ptrace.h. We still need to include the kernel asm/ptrace.h for > > the ptrace_area de

Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.

2017-07-17 Thread Dmitry V. Levin
On Mon, Jul 17, 2017 at 05:44:54PM +0200, Mark Wielaard wrote: > glibc 2.26 changed the sys/ptrace.h header so that it cannot be included > after asm/ptrace.h. We still need to include the kernel asm/ptrace.h for > the ptrace_area definition. Including it after sys/ptrace.h works against > both old

[COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.

2017-07-17 Thread Mark Wielaard
glibc 2.26 changed the sys/ptrace.h header so that it cannot be included after asm/ptrace.h. We still need to include the kernel asm/ptrace.h for the ptrace_area definition. Including it after sys/ptrace.h works against both old and new glibc. Signed-off-by: Mark Wielaard --- backends/ChangeLog