Hi Noah,
On Wed, 2021-07-21 at 15:44 -0400, Noah Sanci via Elfutils-devel wrote:
> Here is a quick error fix.
Thanks, looks good. Failure results should indeed be negative.
For the record the actual fix was:
diff --git a/debuginfod/debuginfod-client.c b/debuginfod/debuginfod-client.c
index 64936
Hi Noah,
On Wed, 2021-07-21 at 14:18 -0400, Noah Sanci via Elfutils-devel wrote:
>
> > > +Note: the client should %-escape characters in /SOURCE/FILE that
> > > are not shown as "unreserved" in section 2.3 of RFC3986.
>
> Please read the new note just to ensure that it's reasonable, as my
> upda
Hello,
Here is a quick error fix.
Noah
From 26aaefe02f5d4ad9187a36d79304edb1b0b450df Mon Sep 17 00:00:00 2001
From: Noah Sanci
Date: Fri, 16 Jul 2021 15:16:20 -0400
Subject: [PATCH] debuginfod: PR28034 - client-side %-escape url characters
When requesting some source files, some URL-inconvenien
Hello,
> On Mon, Jul 19, 2021 at 10:53:17AM -0400, Noah Sanci via Elfutils-devel wrote:
> > When requesting some source files, some URL-inconvenient chars
> > sometimes pop up. Example from f33 libstdc++:
> > /buildid/44d8485cb75512c2ca5c8f70afbd475cae30af4f/source/usr/src/debug/
> > gcc-10.3.1-1
Hi Noah,
On Tue, Jul 20, 2021 at 07:50:11PM +0200, Mark Wielaard wrote:
> > + * run-debuginfod-find.sh: Added a test case ensuring files with %
> > + escapable characters in their paths are accessible.
>
> There are also a couple of changes (fixes?) to the testcases.
> Could those be split ou
Hi -
> Could you rewrite the commit message to describe what is done in this
> patch?
(Yeah, Noah's commit text on his branch was corrected.)
> [...]
> I note that filename is actually the full path component of the URL so
> includes slashes ('/'). curl_easy_escape seems to convert these to %2F
Hi Noah,
On Mon, Jul 19, 2021 at 10:53:17AM -0400, Noah Sanci via Elfutils-devel wrote:
> When requesting some source files, some URL-inconvenient chars
> sometimes pop up. Example from f33 libstdc++:
> /buildid/44d8485cb75512c2ca5c8f70afbd475cae30af4f/source/usr/src/debug/
> gcc-10.3.1-1.fc33.x8
Hello,
Please find the patch for bug 28034 attached.
Noah
From 1e2340a9732bdc8f9a7a207a870e6815c770c23c Mon Sep 17 00:00:00 2001
From: Noah Sanci
Date: Fri, 16 Jul 2021 15:16:20 -0400
Subject: [PATCH] debuginfod: PR28034 - %-escape url characters
When requesting some source files, some URL-inco
