Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-29 Thread Mark Wielaard
Hi Noah, On Wed, 2021-07-28 at 12:23 -0400, Noah Sanci via Elfutils-devel wrote: > This patch fixes a memory leak and slightly alters the PR27983 test, > isolating where its DEBUGINFO_URLS's duplicates are accessible, which > fixes a case of test failure on some systems. Great. I pushed my patch

Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-28 Thread Noah Sanci via Elfutils-devel
Hello This patch fixes a memory leak and slightly alters the PR27983 test, isolating where its DEBUGINFO_URLS's duplicates are accessible, which fixes a case of test failure on some systems. Noah On Wed, Jul 28, 2021 at 10:55 AM Mark Wielaard wrote: > > Hi Noah, > > On Mon, 2021-07-26 at 12:29

Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-28 Thread Mark Wielaard
Hi Noah, On Mon, 2021-07-26 at 12:29 -0400, Noah Sanci via Elfutils-devel wrote: > The realloc returning NULL issue has been resolved and the patch > successfully rebased onto master. Please find these improvements > attached. This looks really good, but I found some small issues. First it turns

Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-26 Thread Noah Sanci via Elfutils-devel
Hello, The realloc returning NULL issue has been resolved and the patch successfully rebased onto master. Please find these improvements attached. Noah From a1b4c2b87f3890c7bf2339b3a69e056d487f74d3 Mon Sep 17 00:00:00 2001 From: Noah Sanci Date: Fri, 9 Jul 2021 14:53:10 -0400 Subject: [PATCH] d

Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-23 Thread Mark Wielaard
Hi Noah, On Thu, 2021-07-22 at 15:22 -0400, Noah Sanci via Elfutils-devel wrote: > PR27983 improvements attached Please do mention the improvements you made. It really does help others see what you thought of. So in this case use asprintf instead of calloc plus sprintf, and (re)use tmpurl instead

Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-22 Thread Noah Sanci via Elfutils-devel
Hello, PR27983 improvements attached Noah Noah On Thu, Jul 22, 2021 at 12:25 PM Noah Sanci wrote: > > Hello > > Please find the updated solution of PR27983 attached. > > Noah > > > Noah > > On Tue, Jul 20, 2021 at 10:42 AM Mark Wielaard wrote: > > > > Hi Noah, > > > > On Mon, Jul 19, 2021 at

Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-22 Thread Noah Sanci via Elfutils-devel
Hello Please find the updated solution of PR27983 attached. Noah Noah On Tue, Jul 20, 2021 at 10:42 AM Mark Wielaard wrote: > > Hi Noah, > > On Mon, Jul 19, 2021 at 09:31:17AM -0400, Noah Sanci wrote: > > On Wed, Jul 14, 2021 at 12:36 PM Mark Wielaard wrote: > > > You deduplicate the full UR

Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-20 Thread Mark Wielaard
Hi Noah, On Mon, Jul 19, 2021 at 09:31:17AM -0400, Noah Sanci wrote: > On Wed, Jul 14, 2021 at 12:36 PM Mark Wielaard wrote: > > You deduplicate the full URLs after they are fully constructed. Would > > it make sense to do the deduplication on server_url, maybe even as > > part of the Count numb

Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-19 Thread Noah Sanci via Elfutils-devel
Hello, On Wed, Jul 14, 2021 at 12:36 PM Mark Wielaard wrote: > You deduplicate the full URLs after they are fully constructed. Would > it make sense to do the deduplication on server_url, maybe even as > part of the Count number of URLs code? That might make the code > simpler. And you can cha

Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-14 Thread Mark Wielaard
Hi Noah, On Fri, Jul 09, 2021 at 03:12:18PM -0400, Noah Sanci via Elfutils-devel wrote: > From e37f49a0fd5f27907584b19336cd250d825acc98 Mon Sep 17 00:00:00 2001 > From: Noah Sanci > Date: Fri, 9 Jul 2021 14:53:10 -0400 > Subject: [PATCH] debuginfod: PR27983 - ignore duplicate urls > > Gazing at

[Bug debuginfod/27983] ignore duplicate urls

2021-07-09 Thread Noah Sanci via Elfutils-devel
Hello, Please find the patch for bug 27983 attached. Noah From e37f49a0fd5f27907584b19336cd250d825acc98 Mon Sep 17 00:00:00 2001 From: Noah Sanci Date: Fri, 9 Jul 2021 14:53:10 -0400 Subject: [PATCH] debuginfod: PR27983 - ignore duplicate urls Gazing at server logs, one sees a minority of clien