On Fri, 2021-07-30 at 09:39 -0400, Noah Sanci wrote:
> Here is the real patch :).
Looks good. Pushed.
Thanks,
Mark
Hello,
Here is the real patch :).
Thanks,
Noah
On Fri, Jul 30, 2021 at 7:11 AM Mark Wielaard wrote:
>
> Hi Noah,
>
> On Thu, 2021-07-29 at 16:29 -0400, Noah Sanci wrote:
> > Why have MAXTIME default to LONG_MAX? Which is long, but different
> > > on
> > > different arches 32/64bit. If MAXSIZE =
Hi Noah,
On Thu, 2021-07-29 at 16:29 -0400, Noah Sanci wrote:
> Why have MAXTIME default to LONG_MAX? Which is long, but different
> > on
> > different arches 32/64bit. If MAXSIZE == 0 means infinite, why not make
> > MAXTIME=0 the same for consistency?
>
> Fixed.
>
> > The bug suggests to also
Hello,
> Why have MAXTIME default to LONG_MAX? Which is long, but different on
> different arches 32/64bit. If MAXSIZE == 0 means infinite, why not make
> MAXTIME=0 the same for consistency?
Fixed.
> The bug suggests to also check the Content-Length header on reciept (in
> case the server didn'
Hi -
> [...] An alternative of passing around the X-DEBUGINFOD-MAXSIZE
> header is doing it all at the client side if we supported HEAD. See
> PR27277. Did you consider that route? [...]
That would require -two- http round-trips (one HEAD, one actual GET).
This way, the requested limit goes out
Hi Noah,
On Mon, 2021-07-26 at 14:56 -0400, Noah Sanci via Elfutils-devel wrote:
> Please find the attached patch for pr 27982. DEBUGINFOD_MAXSIZE and
> MAXTIME were added in this patch to allow users to use more
> constraints when downloading debuginfo.
This looks good. Some high level comments
Hello,
Please find the attached patch for pr 27982. DEBUGINFOD_MAXSIZE and
MAXTIME were added in this patch to allow users to use more
constraints when downloading debuginfo.
Noah
From 93523eb4c8f3f3ca16f3a673369689aec62324cd Mon Sep 17 00:00:00 2001
From: Noah Sanci
Date: Mon, 26 Jul 2021 13:29
