Re: [PATCH] stacktrace: Add missing locale.h

2025-01-30 Thread parona
Hello, On Thursday, January 30th, 2025 at 12:59 PM, Mark Wielaard wrote: > Hi, > > On Thu, Jan 30, 2025 at 12:05:59AM +0000, parona wrote: > > > While building elfutils on musl with different features enabled I > > hit this. > > > > Curiously this also a

[PATCH] stacktrace: Add missing locale.h

2025-01-29 Thread parona
Hi, While building elfutils on musl with different features enabled I hit this. Curiously this also affects glibc if you explicitly build without optimizations. I didn't observe any explicit order with the headers, so I just added it after the rest.From 4a11af08aea00cbe6362e82a14010ca3ea5fa9e7

Re: [PATCH] Link against standalone error library if available

2025-01-29 Thread parona
Hi, On Wednesday, January 29th, 2025 at 2:40 PM, Mark Wielaard wrote: > I definitely like this patch. But when doing an autoreconf -f -v -i > (autoconf 2.27) I get: > > autoheader: warning: missing template: HAVE_ERROR_H > autoheader: warning: Use AC_DEFINE([HAVE_ERROR_H], [], [Description]) >

Re: [PATCH] Link against standalone error library if available

2025-01-28 Thread parona
Hi, On Monday, January 27th, 2025 at 10:40 PM, Mark Wielaard wrote: > My main question/confusion is where the error.h include comes from. > elfutils does support libcs like musl who don't provide error.h but do > provide err.h. Then the build should provide its own error function > through lib/sy

[PATCH] Link against standalone error library if available

2025-01-26 Thread parona
Hello, Background for this patch is https://bugs.gentoo.org/948878 where are user had installed a standalone error implementation for a different package leading to a build failure. Decided to automagically link to it instead of forcing it as a dependency as its only packaged on Gentoo. https