Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2022-07-14 Thread Noah Sanci via Elfutils-devel
Hello, Please find the patch for pr28284 attached Debuginfod and debuginfod clients are now equipped to send and receive http headers prefixed with X-DEBUGINFOD and print them in verbose mode for more context Noah Sanci From 2d4902ca53b80b5cd5689a1ba77e4465c33fea64 Mon Sep 17 00:00:0

[Bug debuginfod/28325] Add debuginfod.service manual page

2022-06-03 Thread Noah Sanci via Elfutils-devel
Hello, Please find the debuginfod.service manual page patch attached. Thanks Noah From 88c355011a78b5030fefedd10630bc99cecaceb6 Mon Sep 17 00:00:00 2001 From: Noah Sanci Date: Thu, 2 Jun 2022 14:26:46 -0400 Subject: [PATCH] Added debuginfod.service.8 manual page. Signed-off-by: Noah Sanci ---

[Bug debuginfod/28577] Make run-...-fd-prefetch-caches.sh test something

2022-05-25 Thread Noah Sanci via Elfutils-devel
PR28577: Make run-debuginfod-fd-prefetch-caches.sh test something Update to the run-debuginfod-fd-prefetch to make the test more sound. From b84dd9b2b36812ea299ff189c7e5557863dd82d2 Mon Sep 17 00:00:00 2001 From: Noah Sanci Date: Fri, 13 May 2022 14:32:27 -0400 Subject: [PATCH] PR285

[Bug debuginfod/29098] set default prefetch limits to >0

2022-05-09 Thread Noah Sanci via Elfutils-devel
debuginfod/debuginfod.cxx: - Added default value to fdcache_prefetch_mds and fdcache_prefetch_fds when -R is specified. Defaults to one half of fdcache's values for those respective variables. These values are only set when -R is specified Note: the ratio of prefetch:fdcache file descrip

Re: debuginfod: Query debuginfod servers before printing response

2021-09-17 Thread Noah Sanci via Elfutils-devel
Hello, Here is an updated patch, removing checks for http response headers which debuginfod is not guaranteed to respond with. These headers caused tests to fail despite receiving sufficient headers to confirm functionality. Regards, Noah Sanci From 28db5f16c44fa7bbd24b221b65aa4d133753355c Mon S

debuginfod: Query debuginfod servers before printing response

2021-09-17 Thread Noah Sanci via Elfutils-devel
Hello, While checking PR27277 on some buildbots, greping would fail in run-debuginfod-response-headers.sh. This was because querying the debuginfod server occurs after checking if the response headers had arrived, leaving the possibility to leave the querying loop before outputting the headers whi

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-09-13 Thread Noah Sanci via Elfutils-devel
Hello, On Sun, Sep 12, 2021 at 3:08 PM Mark Wielaard wrote: > > run-debuginfod-fd-prefetch-caches.sh was updated so that it doesn't > > trip and fail as previously greping for a value that should yield zero > > caused an error. > > I think this part should be in this patch. Do you mean should or

Re: [Bug debuginfod/28034] client-side %-escape url characters

2021-09-13 Thread Noah Sanci via Elfutils-devel
Hello Quick arithmetic change to the original patch with an updated commit message. Best, Noah Sanci From cb2a3957d017f40e1edb35ed8f8fd3b9dee1c6be Mon Sep 17 00:00:00 2001 From: Noah Sanci Date: Thu, 9 Sep 2021 13:10:33 -0400 Subject: [PATCH] debuginfod: PR28034 - No longer escape '/', and loop

Re: [Bug debuginfod/28034] client-side %-escape url characters

2021-09-13 Thread Noah Sanci via Elfutils-devel
Hello, On Sun, Sep 12, 2021 at 1:24 PM Mark Wielaard wrote: > The escaped_string is created outside the loop and reused each time > (good). But... > > + > >/* Initialize each handle. */ > >for (int i = 0; i < num_urls; i++) > > { > > @@ -904,16 +908,23 @@ debuginfod_query_server (de

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-09-10 Thread Noah Sanci via Elfutils-devel
Hello, The updated patch is attached. On Wed, Sep 8, 2021 at 4:56 PM Mark Wielaard wrote: > On Fri, Aug 27, 2021 at 02:38:27PM -0400, Noah Sanci via Elfutils-devel wrote: > > From ed7638571f188e346dd466c195b9ebda028d1c65 Mon Sep 17 00:00:00 2001 > > From: Noah Sanci > > D

Re: [Bug debuginfod/28034] client-side %-escape url characters

2021-09-09 Thread Noah Sanci via Elfutils-devel
Hello, The attached patch %-escapes debuginfod url characters, then unescapes only '/' characters. Previously characters such as '+' were not escaped and caused improper escaping further on in handler_cb. https://sourceware.org/bugzilla/show_bug.cgi?id=28034. On Wed, Sep 8, 2021 at 9:38 AM Mark W

Re: debuginfod: Fracture tests/run-debuginfod-find.sh into specific tests

2021-09-02 Thread Noah Sanci via Elfutils-devel
Hello, As for the rpm/Makefile.am stuff, I think that was a temporary fix for an odd error I got while testing. I just forgot to remove it and see if it would break again. It has been removed and makes now. As for the 'base' idea, I gave it some thought and believe this is the best solution and I

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-08-27 Thread Noah Sanci via Elfutils-devel
Hello, Here is the patch which prints the http headers when verbose. -Noah Sanci On Tue, Aug 24, 2021 at 4:19 AM Mark Wielaard wrote: > > Hi Noah, > > On Mon, 2021-08-23 at 11:11 -0400, Noah Sanci wrote: > > I'm back to working on this patch, thanks for your patience and > > comments. > > > > O

Re: [Bug debuginfod/28034] client-side %-escape url characters

2021-08-27 Thread Noah Sanci via Elfutils-devel
Hello, Next update, removed redundant if statement. -Noah Sanci On Fri, Aug 27, 2021 at 11:07 AM Noah Sanci wrote: > > Hello > > Update 2, no longer append nulls unnecessarily. > > -Noah Sanci > > On Fri, Aug 27, 2021 at 10:44 AM Noah Sanci wrote: > > > > Hello, > > > > Here is an updated patc

Re: [Bug debuginfod/28034] client-side %-escape url characters

2021-08-27 Thread Noah Sanci via Elfutils-devel
Hello Update 2, no longer append nulls unnecessarily. -Noah Sanci On Fri, Aug 27, 2021 at 10:44 AM Noah Sanci wrote: > > Hello, > > Here is an updated patch, using memmove. Much smaller. > > Thanks for the suggestions, > > Noah Sanci > > > On Thu, Aug 26, 2021 at 5:02 PM Frank Ch. Eigler wrote

Re: [Bug debuginfod/28034] client-side %-escape url characters

2021-08-27 Thread Noah Sanci via Elfutils-devel
Hello, Here is an updated patch, using memmove. Much smaller. Thanks for the suggestions, Noah Sanci On Thu, Aug 26, 2021 at 5:02 PM Frank Ch. Eigler wrote: > > Hi - > > >/* PR28034 escape characters in completed url to %hh format. */ > > - char *escaped_string; > > -

[Bug debuginfod/28034] client-side %-escape url characters

2021-08-26 Thread Noah Sanci via Elfutils-devel
Hello, When requesting some source files, some URL-inconvenient chars sometimes pop up. Example from f33 libstdc++: /buildid/44d8485cb75512c2ca5c8f70afbd475cae30af4f/source/usr/src/debug/ gcc-10.3.1-1.fc33.x86_64/obj-x86_64-redhat-linux/x86_64-redhat-linux/ libstdc++-v3/src/c++11/../../../../../l

[Bug debuginfod/27277] Describe retrieved files when verbose

2021-08-25 Thread Noah Sanci via Elfutils-devel
Hello, There appear to exist use cases that intend to simply check for the existence of content in a debuginfod server, without actually downloading it. In HTTP land, the HEAD operation is the natural expression of this. Instead of implementing a HEAD/describe option, allow users, with enough ver

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-08-23 Thread Noah Sanci via Elfutils-devel
Hello, I'm back to working on this patch, thanks for your patience and comments. On Mon, Aug 9, 2021 at 5:27 AM Mark Wielaard wrote: > Yes, separate the verbose printing of http headers (which I really do > like) from providing an interface to query what needs to be done to get > some file (is i

[Bug debuginfod/27277] Describe retrieved files when verbose

2021-08-04 Thread Noah Sanci via Elfutils-devel
Hello, The attached patch dumps the http headers retrieved from the debuginfod server which a file was downloaded from. Some custom headers are now returned such as X-FILE, X-FILE-SIZE, and X-ARCHIVE to give some context about the downloaded files. Noah Sanci From dcbe8672d6be30f92ad8baa2fa157b9b

Re: [Bug debuginfod/27982] added DEBUGINFOD_MAXSIZE and DEBUGINFOD_MAXTIME

2021-07-30 Thread Noah Sanci via Elfutils-devel
Hello, Here is the real patch :). Thanks, Noah On Fri, Jul 30, 2021 at 7:11 AM Mark Wielaard wrote: > > Hi Noah, > > On Thu, 2021-07-29 at 16:29 -0400, Noah Sanci wrote: > > Why have MAXTIME default to LONG_MAX? Which is long, but different > > > on > > > different arches 32/64bit. If MAXSIZE =

Re: [Bug debuginfod/27982] added DEBUGINFOD_MAXSIZE and DEBUGINFOD_MAXTIME

2021-07-29 Thread Noah Sanci via Elfutils-devel
Hello, > Why have MAXTIME default to LONG_MAX? Which is long, but different on > different arches 32/64bit. If MAXSIZE == 0 means infinite, why not make > MAXTIME=0 the same for consistency? Fixed. > The bug suggests to also check the Content-Length header on reciept (in > case the server didn'

Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-28 Thread Noah Sanci via Elfutils-devel
21-07-26 at 12:29 -0400, Noah Sanci via Elfutils-devel wrote: > > The realloc returning NULL issue has been resolved and the patch > > successfully rebased onto master. Please find these improvements > > attached. > > This looks really good, but I found some small issues.

[Bug debuginfod/27982] added DEBUGINFOD_MAXSIZE and DEBUGINFOD_MAXTIME

2021-07-26 Thread Noah Sanci via Elfutils-devel
Hello, Please find the attached patch for pr 27982. DEBUGINFOD_MAXSIZE and MAXTIME were added in this patch to allow users to use more constraints when downloading debuginfo. Noah From 93523eb4c8f3f3ca16f3a673369689aec62324cd Mon Sep 17 00:00:00 2001 From: Noah Sanci Date: Mon, 26 Jul 2021 13:29

Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-26 Thread Noah Sanci via Elfutils-devel
Hello, The realloc returning NULL issue has been resolved and the patch successfully rebased onto master. Please find these improvements attached. Noah From a1b4c2b87f3890c7bf2339b3a69e056d487f74d3 Mon Sep 17 00:00:00 2001 From: Noah Sanci Date: Fri, 9 Jul 2021 14:53:10 -0400 Subject: [PATCH] d

Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-22 Thread Noah Sanci via Elfutils-devel
Hello, PR27983 improvements attached Noah Noah On Thu, Jul 22, 2021 at 12:25 PM Noah Sanci wrote: > > Hello > > Please find the updated solution of PR27983 attached. > > Noah > > > Noah > > On Tue, Jul 20, 2021 at 10:42 AM Mark Wielaard wrote: > > > > Hi Noah, > > > > On Mon, Jul 19, 2021 at

Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-22 Thread Noah Sanci via Elfutils-devel
Hello Please find the updated solution of PR27983 attached. Noah Noah On Tue, Jul 20, 2021 at 10:42 AM Mark Wielaard wrote: > > Hi Noah, > > On Mon, Jul 19, 2021 at 09:31:17AM -0400, Noah Sanci wrote: > > On Wed, Jul 14, 2021 at 12:36 PM Mark Wielaard wrote: > > > You deduplicate the full UR

Re: [Bug debuginfod/28034] %-escape url characters

2021-07-21 Thread Noah Sanci via Elfutils-devel
Hello, Here is a quick error fix. Noah From 26aaefe02f5d4ad9187a36d79304edb1b0b450df Mon Sep 17 00:00:00 2001 From: Noah Sanci Date: Fri, 16 Jul 2021 15:16:20 -0400 Subject: [PATCH] debuginfod: PR28034 - client-side %-escape url characters When requesting some source files, some URL-inconvenien

Re: [debuginfod] Minor run-debuginfod-find.sh test fixes

2021-07-21 Thread Noah Sanci via Elfutils-devel
Updated ChangeLog On Wed, Jul 21, 2021 at 3:06 PM Noah Sanci wrote: > > Hello, > > Here are some small fixes for run-debuginfod-find.sh. > > Noah From 494db032911889c404c59391031554377fa9ee55 Mon Sep 17 00:00:00 2001 From: Noah Sanci Date: Wed, 21 Jul 2021 14:52:07 -0400 Subject: [PATCH] debugi

[debuginfod] Minor run-debuginfod-find.sh test fixes

2021-07-21 Thread Noah Sanci via Elfutils-devel
Hello, Here are some small fixes for run-debuginfod-find.sh. Noah From 0d9c3adf48626d03ea34f03e7bc5f3f9513e64fe Mon Sep 17 00:00:00 2001 From: Noah Sanci Date: Wed, 21 Jul 2021 14:52:07 -0400 Subject: [PATCH] debuginfod: Minor run-debuginfod-find.sh test fixes $PORT3 was left open on error and

Re: [Bug debuginfod/28034] %-escape url characters

2021-07-21 Thread Noah Sanci via Elfutils-devel
Hello, > On Mon, Jul 19, 2021 at 10:53:17AM -0400, Noah Sanci via Elfutils-devel wrote: > > When requesting some source files, some URL-inconvenient chars > > sometimes pop up. Example from f33 libstdc++: > > /buildid/44d8485cb75512c2ca5c8f70afbd475cae30af4f/source/usr/src/

[Bug debuginfod/28034] %-escape url characters

2021-07-19 Thread Noah Sanci via Elfutils-devel
Hello, Please find the patch for bug 28034 attached. Noah From 1e2340a9732bdc8f9a7a207a870e6815c770c23c Mon Sep 17 00:00:00 2001 From: Noah Sanci Date: Fri, 16 Jul 2021 15:16:20 -0400 Subject: [PATCH] debuginfod: PR28034 - %-escape url characters When requesting some source files, some URL-inco

Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-19 Thread Noah Sanci via Elfutils-devel
Hello, On Wed, Jul 14, 2021 at 12:36 PM Mark Wielaard wrote: > You deduplicate the full URLs after they are fully constructed. Would > it make sense to do the deduplication on server_url, maybe even as > part of the Count number of URLs code? That might make the code > simpler. And you can cha

[Bug debuginfod/27983] ignore duplicate urls

2021-07-09 Thread Noah Sanci via Elfutils-devel
Hello, Please find the patch for bug 27983 attached. Noah From e37f49a0fd5f27907584b19336cd250d825acc98 Mon Sep 17 00:00:00 2001 From: Noah Sanci Date: Fri, 9 Jul 2021 14:53:10 -0400 Subject: [PATCH] debuginfod: PR27983 - ignore duplicate urls Gazing at server logs, one sees a minority of clien

Re: [debuginfod/25978]

2021-07-09 Thread Noah Sanci via Elfutils-devel
Hello, That entire 'if' statement is a relic remaining from some ideas I had about testing. I am resending the patch. Thank you for bringing this to my attention, Noah On Fri, Jul 9, 2021 at 10:24 AM Mark Wielaard wrote: > > Hi Noah, > > On Thu, 2021-07-08 at 15:22

[debuginfod/25978]

2021-07-08 Thread Noah Sanci via Elfutils-devel
Hello, Please find the patch information for pr25978 attached. Noah Sanci From af80431af96b3d1f921df264672829db71b46d20 Mon Sep 17 00:00:00 2001 From: Noah Date: Thu, 10 Jun 2021 10:29:45 -0400 Subject: [PATCH] debuginfod: PR25978 - Created the prefetch fdcache The debuginfod fdcache-prefetch l

PR27711

2021-07-08 Thread Noah Sanci via Elfutils-devel
Hello, Find the patch information for pr27711 attached . Noah Sanci From f126b48bf1131070d80e063bfd296ddb69af8c9a Mon Sep 17 00:00:00 2001 From: Noah Date: Wed, 7 Jul 2021 14:40:10 -0400 Subject: [PATCH] debuginfod: PR27711 - Use -I/-X regexes during groom phase The debuginfod -I/-X regexes ope

PR: 25978

2021-07-02 Thread Noah Sanci via Elfutils-devel
diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog index 286c910a..06d03e72 100644 --- a/debuginfod/ChangeLog +++ b/debuginfod/ChangeLog @@ -1,3 +1,9 @@ +2021-06-28 Noah Sanci + + PR25978 + * debuginfod.cxx: Added command line options + --fdcache-prefetch-fds/mbs and associated metrics/funct

PR27711

2021-07-01 Thread Noah Sanci via Elfutils-devel
diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog index 286c910a..5afbafcd 100644 --- a/debuginfod/ChangeLog +++ b/debuginfod/ChangeLog @@ -1,3 +1,8 @@ +2021-07-01 Noah Sanci + PR27711 + * debuginfod.cxx (groom): Allowed the use of regexes during the + grooming process. +